Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

tools: consolidate and simplify .editorconfig deps section#62887

Closed
watilde wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
watilde:tools-editorconfigwatilde/node:tools-editorconfigCopy head branch name to clipboard
Closed

tools: consolidate and simplify .editorconfig deps section#62887
watilde wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
watilde:tools-editorconfigwatilde/node:tools-editorconfigCopy head branch name to clipboard

Conversation

@watilde

@watilde watilde commented Apr 22, 2026

Copy link
Copy Markdown
Member

Separate deps/** into its own .editorconfig section and add insert_final_newline = unset to avoid applying project formatting rules to vendored dependencies.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 22, 2026
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@watilde watilde force-pushed the tools-editorconfig branch 2 times, most recently from 1df4e04 to fe8397e Compare April 23, 2026 11:07
@watilde

watilde commented Apr 23, 2026

Copy link
Copy Markdown
Member Author

rebase and make the commit Verified.

@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@watilde watilde added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2026
watilde added a commit that referenced this pull request Apr 26, 2026
PR-URL: #62887
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@watilde

watilde commented Apr 26, 2026

Copy link
Copy Markdown
Member Author

landed in 11f76b4

@watilde watilde closed this Apr 26, 2026
@watilde watilde deleted the tools-editorconfig branch April 26, 2026 10:01
aduh95 pushed a commit that referenced this pull request May 5, 2026
PR-URL: #62887
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 7, 2026
PR-URL: #62887
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
araujogui pushed a commit to araujogui/node that referenced this pull request May 26, 2026
PR-URL: nodejs#62887
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.