doc: fix Argon2 parameter bounds#62868
Merged
nodejs-github-bot merged 1 commit intoApr 23, 2026
nodejs:mainnodejs/node:mainfrom
tniessen:doc-crypto-fix-argon2-paramstniessen/node:doc-crypto-fix-argon2-paramsCopy head branch name to clipboard
Merged
doc: fix Argon2 parameter bounds#62868nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom tniessen:doc-crypto-fix-argon2-paramstniessen/node:doc-crypto-fix-argon2-paramsCopy head branch name to clipboard
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
tniessen:doc-crypto-fix-argon2-paramstniessen/node:doc-crypto-fix-argon2-paramsCopy head branch name to clipboard
Conversation
The bounds are supposed to be inclusive, not exclusive.
Collaborator
|
Review requested:
|
panva
approved these changes
Apr 21, 2026
richardlau
approved these changes
Apr 21, 2026
Member
|
Side note: we have a lot of these, including in error msgs |
Collaborator
|
Landed in 5f92b6d |
aduh95
pushed a commit
that referenced
this pull request
May 5, 2026
The bounds are supposed to be inclusive, not exclusive. PR-URL: #62868 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
aduh95
pushed a commit
that referenced
this pull request
May 7, 2026
The bounds are supposed to be inclusive, not exclusive. PR-URL: #62868 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
araujogui
pushed a commit
to araujogui/node
that referenced
this pull request
May 26, 2026
The bounds are supposed to be inclusive, not exclusive. PR-URL: nodejs#62868 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bounds are supposed to be inclusive, not exclusive.