tools: update nixpkgs-unstable to ab72be9733b41190ea34f1422a3e4e243ed#62821
Merged
nodejs-github-bot merged 1 commit intoApr 21, 2026
mainnodejs/node:mainfrom
actions/tools-update-nixpkgs-unstablenodejs/node:actions/tools-update-nixpkgs-unstableCopy head branch name to clipboard
Merged
tools: update nixpkgs-unstable to ab72be9733b41190ea34f1422a3e4e243ed#62821nodejs-github-bot merged 1 commit intomainnodejs/node:mainfrom actions/tools-update-nixpkgs-unstablenodejs/node:actions/tools-update-nixpkgs-unstableCopy head branch name to clipboard
nodejs-github-bot merged 1 commit into
mainnodejs/node:mainfrom
actions/tools-update-nixpkgs-unstablenodejs/node:actions/tools-update-nixpkgs-unstableCopy head branch name to clipboard
Conversation
panva
approved these changes
Apr 19, 2026
cjihrig
approved these changes
Apr 19, 2026
8fc5df6 to
dd8f89c
Compare
Contributor
|
Removed the revert of numtide/treefmt@b96016b now that the fix has landed upstream (tested on https://github.com/nodejs/node-auto-test/actions/runs/24636421675). Also bumped the version to one with |
panva
approved these changes
Apr 19, 2026
dd8f89c to
9822fa1
Compare
panva
approved these changes
Apr 20, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
9822fa1 to
bd9ab76
Compare
aduh95
approved these changes
Apr 20, 2026
aduh95
left a comment
Contributor
There was a problem hiding this comment.
Does it make sense for you to sign off something you did not author?
Member
|
rebase from main changed the commit to me as the author, for some reason, so by policy i must sign off 😀. do you want to close this and trigger a fresh sync instead, or just tell me how to proceed. |
Contributor
Collaborator
Author
|
Landed in 3e32a13 |
twoodslong
reviewed
Apr 21, 2026
Member
|
Interestingly, the intermittent lint-nix timeouts appear to have recurred since this commit. |
Contributor
|
I did another test:
13 timeout over 512 runs is roughly 2.5%, which is not nothing, but all things considered 97.5% of reliability is a pretty high score for a Node.js CI :p In numtide/treefmt#677 (comment), I have found very different figures, so I wonder if there's something else affecting the reliability. |
aduh95
pushed a commit
that referenced
this pull request
May 5, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #62821 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
araujogui
pushed a commit
to araujogui/node
that referenced
this pull request
May 26, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: nodejs#62821 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of nixpkgs-unstable to ab72be9733b41190ea34f1422a3e4e243ed.