doc: fix stray carriage return in packages.md#62350
Merged
Merged
doc: fix stray carriage return in packages.md#62350
Conversation
Collaborator
|
Review requested:
|
Contributor
|
Fast-track has been requested by @panva. Please 👍 to approve. |
aduh95
approved these changes
Mar 20, 2026
Contributor
aduh95
left a comment
There was a problem hiding this comment.
Very hard to spot, a shame GitHub UI nor the linter is able to help us catch that
legendecas
approved these changes
Mar 20, 2026
atlowChemi
approved these changes
Mar 20, 2026
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62350 ✔ Done loading data for nodejs/node/pull/62350 ----------------------------------- PR info ------------------------------------ Title doc: fix stray carriage return in packages.md (#62350) Author Filip Skokan <panva.ip@gmail.com> (@panva) Branch panva:stray-carriage-return -> nodejs:main Labels doc, fast-track Commits 1 - doc: fix stray carriage return in packages.md Committers 1 - Filip Skokan <panva.ip@gmail.com> PR-URL: https://github.com/nodejs/node/pull/62350 Refs: https://openjs-foundation.slack.com/archives/C019Y2T6STH/p1774015976262609 Refs: https://github.com/nodejs/node/pull/62302 Refs: https://github.com/nodejs/node/actions/runs/23347139396/job/67915524762?pr=61767 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62350 Refs: https://openjs-foundation.slack.com/archives/C019Y2T6STH/p1774015976262609 Refs: https://github.com/nodejs/node/pull/62302 Refs: https://github.com/nodejs/node/actions/runs/23347139396/job/67915524762?pr=61767 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 20 Mar 2026 14:26:56 GMT ✔ Approvals: 5 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/62350#pullrequestreview-3981907555 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/62350#pullrequestreview-3982025863 ✔ - René (@Renegade334): https://github.com/nodejs/node/pull/62350#pullrequestreview-3982152226 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/62350#pullrequestreview-3982194999 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/62350#pullrequestreview-3982214292 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 62350 From https://github.com/nodejs/node * branch refs/pull/62350/merge -> FETCH_HEAD ✔ Fetched commits as 052aec7127f4..385a91a55f03 -------------------------------------------------------------------------------- [main ba5c2fd55c] doc: fix stray carriage return in packages.md Author: Filip Skokan <panva.ip@gmail.com> Date: Fri Mar 20 15:14:17 2026 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- doc: fix stray carriage return in packages.md
Temporary files removed.
|
Member
|
Landed (kicking and screaming) in b2c5235 |
Contributor
|
To make everyone's life easier, I've fixed the original commit when cherry-picking it on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a stray carriage return that's wreaking havoc in local and CI checkouts.
Refs: https://openjs-foundation.slack.com/archives/C019Y2T6STH/p1774015976262609
Refs: #62302
Refs: https://github.com/nodejs/node/actions/runs/23347139396/job/67915524762?pr=61767