Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Revert "inspector: fix compressed responses"#61502

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
aduh95:revert-flaky-testaduh95/node:revert-flaky-testCopy head branch name to clipboard
Jan 26, 2026
Merged

Revert "inspector: fix compressed responses"#61502
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
aduh95:revert-flaky-testaduh95/node:revert-flaky-testCopy head branch name to clipboard

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Jan 24, 2026

This reverts #61226, which introduced a flaky test.

Fixes: #61501

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 24, 2026

Review requested:

  • @nodejs/inspector

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Jan 24, 2026
@aduh95 aduh95 mentioned this pull request Jan 24, 2026
Closed
@aduh95 aduh95 added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jan 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 24, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.79%. Comparing base (1ad04e2) to head (4dea76e).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61502      +/-   ##
==========================================
- Coverage   89.80%   89.79%   -0.01%     
==========================================
  Files         672      672              
  Lines      203907   203780     -127     
  Branches    39203    39181      -22     
==========================================
- Hits       183121   182994     -127     
- Misses      13113    13117       +4     
+ Partials     7673     7669       -4
Files with missing lines Coverage Δ
lib/internal/inspector/network.js 95.95% <ø> (-0.94%) ⬇️
lib/internal/inspector/network_http.js 95.27% <100.00%> (-0.67%) ⬇️
lib/internal/inspector/network_http2.js 87.73% <100.00%> (-1.59%) ⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 24, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71003/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 24, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71008/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 25, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71015/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 26, 2026
@nodejs-github-bot nodejs-github-bot merged commit a27052f into nodejs:main Jan 26, 2026
91 of 92 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 26, 2026

Landed in a27052f

@aduh95 aduh95 deleted the revert-flaky-test branch January 26, 2026 11:13
@RafaelGSS RafaelGSS mentioned this pull request Apr 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@legendecas legendecas legendecas approved these changes

Assignees

No one assigned

Labels

dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. http2 Issues or PRs related to the http2 subsystem. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test-inspector-network-http2-compressed is flaky

5 participants

@aduh95 @nodejs-github-bot @lpinca @cjihrig @legendecas
Morty Proxy This is a proxified and sanitized view of the page, visit original site.