fix: keep proxies opaque in util.inspect when showProxy is false#61068
Closed
azadgupta1 wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
azadgupta1:fix-util-inspect-proxy-opaqueazadgupta1/node:fix-util-inspect-proxy-opaqueCopy head branch name to clipboard
Closed
fix: keep proxies opaque in util.inspect when showProxy is false#61068azadgupta1 wants to merge 1 commit intonodejs:mainnodejs/node:mainfrom azadgupta1:fix-util-inspect-proxy-opaqueazadgupta1/node:fix-util-inspect-proxy-opaqueCopy head branch name to clipboard
azadgupta1 wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
azadgupta1:fix-util-inspect-proxy-opaqueazadgupta1/node:fix-util-inspect-proxy-opaqueCopy head branch name to clipboard
Conversation
8e4666e to
f9a0b52
Compare
f9a0b52 to
35e258c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61068 +/- ##
==========================================
- Coverage 88.55% 88.42% -0.14%
==========================================
Files 703 703
Lines 208260 208550 +290
Branches 40155 40135 -20
==========================================
- Hits 184430 184410 -20
- Misses 15837 16148 +311
+ Partials 7993 7992 -1
🚀 New features to boost your workflow:
|
Member
|
I think this is the opposite of what @jasnell wanted? |
BridgeAR
requested changes
Dec 15, 2025
BridgeAR
left a comment
Member
There was a problem hiding this comment.
This actually does not fix the issue, while it fails many tests
Member
|
Closing in favor of #61077 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
util.inspectunwraps proxies even whenshowProxyis false,which can trigger traps for nested proxies and lead to unexpected errors.
This change:
showProxyis false.showProxyis disabled.Refs: #61061