build: add flag to compile V8 with Temporal support#60693
build: add flag to compile V8 with Temporal support#60693targos wants to merge 1 commit into
Conversation
It won't work until we build `temporal_capi`, but is a step forward. Refs: nodejs#58730
|
Review requested:
|
|
I'm getting |
|
As written in the commit message, this won't work. |
|
I don't want to be blocking progress on this work, so I'm trying to include the results of my experiments in small steps so that someone else can build on it (and doesn't have to start from scratch) |
|
The commit message makes it sound like the only thing I need to do is to provide a build version of temporal_rs, which is what I've done but I'm getting the error above, so I do think something's missing here. I'm suggesting Lines 24 to 35 in a201250 |
|
There are many things missing, and I intend to do other PRs after this one. I thought it would be easier to get the changes in small steps 😄. |
|
FWIW if I apply the following diff: diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
index c3ec7e3ee92..71d27300d66 100644
--- a/tools/v8_gypfiles/v8.gyp
+++ b/tools/v8_gypfiles/v8.gyp
@@ -27,6 +27,11 @@
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "torque_files =.*?v8_enable_i18n_support.*?torque_files \\+= ")',
],
}],
+ ['v8_enable_temporal_support==1', {
+ 'torque_files': [
+ '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "torque_files =.*?v8_enable_temporal_support.*?torque_files \\+= ")',
+ ],
+ }],
['v8_enable_webassembly==1', {
'torque_files': [
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "torque_files =.*?v8_enable_webassembly.*?torque_files \\+= ")',I get further, but I'm getting another error: |
|
https://github.com/targos/node/tree/v8-temporal contains this change and other similar ones. |
|
|
|
Chromium is already using v0.1.2, I expect V8 will catch up soon if they haven't already: chromium/chromium@f700ec5 EDIT: indeed, v8/v8@0cbecc1 |
Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #60703 Refs: #58730 Refs: #60693 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #60703 Refs: #58730 Refs: #60693 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #60703 Refs: #58730 Refs: #60693 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #60703 Refs: #58730 Refs: #60693 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
It won't work until we build
temporal_capi, but is a step forward.Refs: #58730