Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

test: add test for QUIC handshake against test client/server#60064

Closed
jasnell wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
jasnell:jasnell/test-quic-handshakejasnell/node:jasnell/test-quic-handshakeCopy head branch name to clipboard
Closed

test: add test for QUIC handshake against test client/server#60064
jasnell wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
jasnell:jasnell/test-quic-handshakejasnell/node:jasnell/test-quic-handshakeCopy head branch name to clipboard

Conversation

@jasnell

@jasnell jasnell commented Sep 28, 2025

Copy link
Copy Markdown
Member

No description provided.

@jasnell jasnell requested review from Qard and anonrig September 28, 2025 20:15
@jasnell jasnell added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Sep 28, 2025
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 28, 2025
@codecov

codecov Bot commented Sep 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (10df38a) to head (8253f1c).
⚠️ Report is 1040 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60064      +/-   ##
==========================================
+ Coverage   88.45%   88.55%   +0.09%     
==========================================
  Files         703      703              
  Lines      207834   207833       -1     
  Branches    40037    40030       -7     
==========================================
+ Hits       183844   184041     +197     
+ Misses      15967    15795     -172     
+ Partials     8023     7997      -26     

see 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread test/sequential/test-quic-client-handshake-with-test-server.mjs
@Qard

Qard commented Sep 29, 2025

Copy link
Copy Markdown
Member

Other than the already mentioned test failure, LGTM.

Comment thread test/sequential/test-quic-client-handshake-with-test-server.mjs
@jasnell jasnell force-pushed the jasnell/test-quic-handshake branch from 98caea6 to 5946d0e Compare October 4, 2025 13:19
@jasnell jasnell requested a review from trivikr October 4, 2025 13:20
@jasnell jasnell force-pushed the jasnell/test-quic-handshake branch from 5946d0e to 8253f1c Compare October 5, 2025 12:56
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@jasnell jasnell closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.