Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

test: update test-abortsignal-cloneable to use node:test - #54581

#54581
Closed
jasnell wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
jasnell:use-test-in-test-abortsignal-cloneablejasnell/node:use-test-in-test-abortsignal-cloneableCopy head branch name to clipboard
Closed

test: update test-abortsignal-cloneable to use node:test#54581
jasnell wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
jasnell:use-test-in-test-abortsignal-cloneablejasnell/node:use-test-in-test-abortsignal-cloneableCopy head branch name to clipboard

Conversation

@jasnell

@jasnell jasnell commented Aug 27, 2024

Copy link
Copy Markdown
Member

No description provided.

@jasnell
jasnell requested review from anonrig and mcollina August 27, 2024 01:54
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 27, 2024
@codecov

This comment was marked as outdated.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2024
@nodejs-github-bot

This comment was marked as outdated.

@jasnell

This comment was marked as outdated.

@jasnell
jasnell force-pushed the use-test-in-test-abortsignal-cloneable branch from 5bbb612 to 71a5123 Compare August 29, 2024 18:42
@jasnell
jasnell force-pushed the use-test-in-test-abortsignal-cloneable branch from 71a5123 to ae9c91d Compare August 29, 2024 18:54
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

jasnell added a commit that referenced this pull request Aug 29, 2024
PR-URL: #54581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell

jasnell commented Aug 29, 2024

Copy link
Copy Markdown
Member Author

Landed in 2bd0f99

@jasnell jasnell closed this Aug 29, 2024
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 30, 2024
sendoru pushed a commit to sendoru/node that referenced this pull request Sep 1, 2024
PR-URL: nodejs#54581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Sep 1, 2024
PR-URL: #54581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#54581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#54581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.