test: deflake test-http2-buffersize#39591
Closed
lpinca wants to merge 1 commit into
nodejs:masternodejs/node:masterfrom
lpinca:deflake/test-http2-buffersizelpinca/node:deflake/test-http2-buffersizeCopy head branch name to clipboard
Closed
test: deflake test-http2-buffersize#39591lpinca wants to merge 1 commit intonodejs:masternodejs/node:masterfrom lpinca:deflake/test-http2-buffersizelpinca/node:deflake/test-http2-buffersizeCopy head branch name to clipboard
lpinca wants to merge 1 commit into
nodejs:masternodejs/node:masterfrom
lpinca:deflake/test-http2-buffersizelpinca/node:deflake/test-http2-buffersizeCopy head branch name to clipboard
Conversation
Trott
approved these changes
Jul 30, 2021
This is basically a revert of nodejs@c452632. The problem with that commit is that the promises returned by `once(server, 'stream')` are all resolved with the same stream when the first `'stream'` event is emitted. Refs: nodejs#39525 (comment)
83c58b9 to
9807960
Compare
addaleax
approved these changes
Jul 30, 2021
Collaborator
Collaborator
Collaborator
Member
Author
|
Landed in 0f9434a. |
lpinca
added a commit
that referenced
this pull request
Aug 2, 2021
This is basically a revert of c452632. The problem with that commit is that the promises returned by `once(server, 'stream')` are all resolved with the same stream when the first `'stream'` event is emitted. Refs: #39525 (comment) PR-URL: #39591 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
This is basically a revert of c452632. The problem with that commit is that the promises returned by `once(server, 'stream')` are all resolved with the same stream when the first `'stream'` event is emitted. Refs: #39525 (comment) PR-URL: #39591 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
This is basically a revert of c452632. The problem with that commit is that the promises returned by `once(server, 'stream')` are all resolved with the same stream when the first `'stream'` event is emitted. Refs: #39525 (comment) PR-URL: #39591 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically a revert of
c452632.
The problem with that commit is that the promises returned by
once(server, 'stream')are all resolved with the same stream when thefirst
'stream'event is emitted.Refs: #39525 (comment)