Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

doc: run license-builder#39360

Closed
github-actions[bot] wants to merge 1 commit into
masternodejs/node:masterfrom
create-or-update-pull-request-actionnodejs/node:create-or-update-pull-request-actionCopy head branch name to clipboard
Closed

doc: run license-builder#39360
github-actions[bot] wants to merge 1 commit into
masternodejs/node:masterfrom
create-or-update-pull-request-actionnodejs/node:create-or-update-pull-request-actionCopy head branch name to clipboard

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

License is likely out of date. This is an automatically generated PR by the license-builder.yml GitHub Action, which runs license-builder.sh and submits a new PR or updates an existing PR.

@github-actions github-actions Bot added the meta Issues and PRs related to the general management of the project. label Jul 12, 2021
devsnek
devsnek previously approved these changes Jul 12, 2021
@devsnek devsnek dismissed their stale review July 12, 2021 00:13

misread

@devsnek

devsnek commented Jul 12, 2021

Copy link
Copy Markdown
Member

cc @legendecas

@legendecas

Copy link
Copy Markdown
Member

A file from gtest is located at src/gtest too: https://github.com/nodejs/node/blob/master/src/gtest/gtest_prod.h. If I understand correctly, that should be listed at LICENSE too?

@targos

targos commented Jul 12, 2021

Copy link
Copy Markdown
Member

I'm curious, what's the change that introduced this?

@legendecas

Copy link
Copy Markdown
Member

@targos 392213a this one

@targos targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@targos targos closed this Jul 16, 2021
@targos targos deleted the create-or-update-pull-request-action branch July 16, 2021 16:02
@targos

targos commented Jul 16, 2021

Copy link
Copy Markdown
Member

Fixed in #39386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.