Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ffeebeb

Browse filesBrowse files
joyeecheungaduh95
authored andcommitted
test: make test-worker-prof more tolerant
It seems after the recent V8 upgrade, it's no longer safe to assume there'll be 15 ticks per 1500ms. Lower it to 10 ticks. PR-URL: #60272 Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-10-15.md Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent bac70c6 commit ffeebeb
Copy full SHA for ffeebeb

File tree

Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Collapse file

‎test/sequential/test-worker-prof.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-worker-prof.js
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ if (process.argv[2] === 'child') {
7777
// When not tracking Worker threads, only 1 or 2 ticks would
7878
// have been recorded.
7979
// prof_sampling_interval is by default 1 millisecond. A higher SPIN_MS
80-
// should result in more ticks, while 15 should be safe on most machines.
81-
assert(workerTicks.length > 15, `worker ticks <= 15:\n${workerTicks.join('\n')}`);
82-
assert(parentTicks.length > 15, `parent ticks <= 15:\n${parentTicks.join('\n')}`);
80+
// should result in more ticks, while 10 should be safe on most machines.
81+
assert(workerTicks.length > 10, `worker ticks <= 10:\n${workerTicks.join('\n')}`);
82+
assert(parentTicks.length > 10, `parent ticks <= 10:\n${parentTicks.join('\n')}`);
8383
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.