Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

test: make test-worker-prof more tolerant #60272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2025
Merged

test: make test-worker-prof more tolerant #60272

merged 1 commit into from
Oct 17, 2025
+3 −3

Conversation

joyeecheung
Copy link
Member

It seems after the recent V8 upgrade, it's no longer safe to assume there'll be 15 ticks per 1500ms. Lower it to 10 ticks.

This failed 19 PRs out of the last 100 CI runs in the latest reliability report.

Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-10-15.md

@joyeecheung
test: make test-worker-prof more tolerant
e223c3d 
It seems after the recent V8 upgrade, it's no longer safe to assume
there'll be 15 ticks per 1500ms. Lower it to 10 ticks.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 15, 2025
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (1d2b89a) to head (e223c3d).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60272      +/-   ##
==========================================
- Coverage   88.57%   88.56%   -0.02%     
==========================================
  Files         704      704              
  Lines      208323   208323              
  Branches    40037    40037              
==========================================
- Hits       184531   184492      -39     
- Misses      15811    15856      +45     
+ Partials     7981     7975       -6

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69747/

targos
targos approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that it's already with the V8 update that the time was increased from 1000ms.
I don't understand this test enough to judge whether the numbers of ticks are still testing what we want.

@Hritikk999
Copy link

ALREADY REPORTED

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69755/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69776/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69782/

@joyeecheung
Copy link
Member Author

joyeecheung commented Oct 17, 2025 •
edited
Loading

I don't understand this test enough to judge whether the numbers of ticks are still testing what we want.

I think as long as the number is not 0, it's "working", though may be working terribly bad if it doesn't have enough sticks for users to understand the profile, but that's not really an issue for Node.js to fix, and flaking the Node.js CI with V8 profiling inefficacy doesn't really help anyone..

cc @addaleax

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69786/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69795/

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 17, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 17, 2025
@nodejs-github-bot nodejs-github-bot merged commit 8429d9a into nodejs:main Oct 17, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8429d9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joyeecheung @nodejs-github-bot @Hritikk999 @lpinca @targos
Morty Proxy This is a proxified and sanitized view of the page, visit original site.