Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit fca56a4

Browse filesBrowse files
ckerraduh95
authored andcommitted
src: add missing <cstdlib> for abort() declaration
builtin_info.cc calls `abort()` but didn't call `<cstdlib>` to pick up its declaration. This has been working because `abort()` got picked up by a transitive declaration from another header, but it broke in Electron when we rolled our LLVM libc++ snapshot from commit 8e870711923 to 9aaa9a2ee87. Signed-off-by: Charles Kerr <charles@charleskerr.com> PR-URL: #63001 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 712a15d commit fca56a4
Copy full SHA for fca56a4

1 file changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/builtin_info.cc‎

Copy file name to clipboardExpand all lines: src/builtin_info.cc
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#include "builtin_info.h"
2+
#include <cstdlib>
23

34
namespace node {
45
namespace builtins {
@@ -41,7 +42,7 @@ std::string GetBuiltinSourceTypeName(BuiltinSourceType type) {
4142
case BuiltinSourceType::kSourceTextModule:
4243
return "kSourceTextModule";
4344
}
44-
abort();
45+
std::abort();
4546
}
4647

4748
} // namespace builtins

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.