Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit eec896c

Browse filesBrowse files
dramforeverkxxt
authored and
aduh95
committed
deps: V8: backport 6a0a25abaed3
Original commit message: [riscv] Fix sp handling in MacroAssembler::LeaveFrame Keep sp <= fp to ensure that data right above fp doesn't get clobbered by an inopportune signal and its handler. Such clobbering can happen in e.g. Node.js when JIT-compiled code is interrupted by a SIGCHLD handler. Bug: None Change-Id: Ief0836032ada7942e89f081f7605f61632c4d414 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7540554 Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Commit-Queue: Yahan Lu (LuYahan) <yahan@iscas.ac.cn> Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Cr-Commit-Position: refs/heads/main@{#105069} Refs: v8/v8@6a0a25a Co-authored-by: kxxt <rsworktech@outlook.com> PR-URL: #61666 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent b6ae1fc commit eec896c
Copy full SHA for eec896c

3 files changed

+4-2Lines changed: 4 additions & 2 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.19',
41+
'v8_embedder_string': '-node.20',
4242

4343
##### V8 defaults for Node.js #####
4444

Collapse file

‎deps/v8/AUTHORS‎

Copy file name to clipboardExpand all lines: deps/v8/AUTHORS
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,7 @@ Vadim Gorbachev <bmsdave@gmail.com>
300300
Varun Varada <varuncvarada@gmail.com>
301301
Victor Costan <costan@gmail.com>
302302
Victor Polevoy <fx@thefx.co>
303+
Vivian Wang <wangruikang@iscas.ac.cn>
303304
Vlad Burlik <vladbph@gmail.com>
304305
Vladimir Kempik <vladimir.kempik@syntacore.com>
305306
Vladimir Krivosheev <develar@gmail.com>
Collapse file

‎deps/v8/src/codegen/riscv/macro-assembler-riscv.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/codegen/riscv/macro-assembler-riscv.cc
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6712,9 +6712,10 @@ void MacroAssembler::EnterFrame(StackFrame::Type type) {
67126712

67136713
void MacroAssembler::LeaveFrame(StackFrame::Type type) {
67146714
ASM_CODE_COMMENT(this);
6715-
AddWord(sp, fp, 2 * kSystemPointerSize);
6715+
Move(sp, fp);
67166716
LoadWord(ra, MemOperand(fp, 1 * kSystemPointerSize));
67176717
LoadWord(fp, MemOperand(fp, 0 * kSystemPointerSize));
6718+
AddWord(sp, sp, 2 * kSystemPointerSize);
67186719
}
67196720

67206721
void MacroAssembler::EnterExitFrame(Register scratch, int stack_space,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.