Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit e35814b

Browse filesBrowse files
tniessenaduh95
tniessen
authored and
aduh95
committed
src: add missing override specifier to Clean()
The `CallbackInfo::Clean()` method overrides `Cleanable::Clean()` and should be marked as `override`, both because it is good practice to do so and for consistency with the rest of the code base. PR-URL: #61429 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Aviv Keller <me@aviv.sh>
1 parent e9a3426 commit e35814b
Copy full SHA for e35814b

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/node_buffer.cc‎

Copy file name to clipboardExpand all lines: src/node_buffer.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ class CallbackInfo : public Cleanable {
9898
CallbackInfo& operator=(const CallbackInfo&) = delete;
9999

100100
private:
101-
void Clean();
101+
void Clean() override;
102102
inline void OnBackingStoreFree();
103103
inline void CallAndResetCallback();
104104
inline CallbackInfo(Environment* env,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.