Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e352a4e

Browse filesBrowse files
tniessenmarco-ippolito
authored andcommitted
src: update outdated references to spec sections
The exact section has changed in recent versions of ECMA-262, so fix the section number and explicitly mark the edition of the standard to avoid having to update it in the future. PR-URL: #53832 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent 206c668 commit e352a4e
Copy full SHA for e352a4e

2 files changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/util-inl.h‎

Copy file name to clipboardExpand all lines: src/util-inl.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ void ArrayBufferViewContents<T, S>::ReadValue(v8::Local<v8::Value> buf) {
582582
}
583583
}
584584

585-
// ECMA262 20.1.2.5
585+
// ECMA-262, 15th edition, 21.1.2.5. Number.isSafeInteger
586586
inline bool IsSafeJsInt(v8::Local<v8::Value> v) {
587587
if (!v->IsNumber()) return false;
588588
double v_d = v.As<v8::Number>()->Value();
Collapse file

‎src/util.h‎

Copy file name to clipboardExpand all lines: src/util.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ void DumpJavaScriptBacktrace(FILE* fp);
217217
#define UNREACHABLE(...) \
218218
ERROR_AND_ABORT("Unreachable code reached" __VA_OPT__(": ") __VA_ARGS__)
219219

220-
// ECMA262 20.1.2.6 Number.MAX_SAFE_INTEGER (2^53-1)
220+
// ECMA-262, 15th edition, 21.1.2.6. Number.MAX_SAFE_INTEGER (2^53-1)
221221
constexpr int64_t kMaxSafeJsInteger = 9007199254740991;
222222

223223
inline bool IsSafeJsInt(v8::Local<v8::Value> v);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.