Commit df79b7d
committed
src: fix missing handlescope bug in inspector
Fix a regression that was introduced in commit 5886e20 ("inspector:
track async stacks when necessary") and that I overlooked during review:
the persistent handle with the callback must be rematerialized *after*
the `v8::HandleScope` is created, not before.
Apparently `test/sequential/test-inspector-async-call-stack.js` has
no test coverage for this scenario and I'm out of good ideas on how
to create a concise and reliable test case.
Fixes: #17496
PR-URL: #17539
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>1 parent d865395 commit df79b7dCopy full SHA for df79b7d
File tree
Expand file treeCollapse file tree
2 files changed
+8
-7
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
2 files changed
+8
-7
lines changedOpen diff view settings
Collapse file
+6-6Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
30 | 30 | |
31 | 31 | |
32 | 32 | |
| 33 | + |
33 | 34 | |
34 | 35 | |
35 | 36 | |
| ||
613 | 614 | |
614 | 615 | |
615 | 616 | |
616 | | - |
617 | | - |
| 617 | + |
618 | 618 | |
619 | 619 | |
620 | 620 | |
| ||
625 | 625 | |
626 | 626 | |
627 | 627 | |
628 | | - |
629 | | - |
| 628 | + |
630 | 629 | |
631 | 630 | |
632 | 631 | |
| ||
635 | 634 | |
636 | 635 | |
637 | 636 | |
638 | | - |
| 637 | + |
639 | 638 | |
| 639 | + |
640 | 640 | |
641 | | - |
| 641 | + |
642 | 642 | |
643 | 643 | |
644 | 644 | |
|
Collapse file
+2-1Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
96 | 96 | |
97 | 97 | |
98 | 98 | |
99 | | - |
| 99 | + |
| 100 | + |
100 | 101 | |
101 | 102 | |
102 | 103 | |
|
0 commit comments