Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d7eccac

Browse filesBrowse files
miladfarcaRafaelGSS
authored andcommitted
deps: V8: cherry-pick daf4656ba85e
Original commit message: Mark MemCopyAndSwitchEndianness src input as `const` Needed after this CL: http://crrev.com/c/7600437 Currently getting the following error: ``` candidate function not viable: no known conversion from 'const unsigned char *' to 'void *' ``` Change-Id: I0c0f065b822e0f95ffd06207d280fc8b7bab4403 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7601332 Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Cr-Commit-Position: refs/heads/main@{#105413} Refs: v8/v8@daf4656 PR-URL: #61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> (cherry picked from commit e6f9cd5)
1 parent 3ee1ea7 commit d7eccac
Copy full SHA for d7eccac

3 files changed

+14-14Lines changed: 14 additions & 14 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.10',
41+
'v8_embedder_string': '-node.11',
4242

4343
##### V8 defaults for Node.js #####
4444

Collapse file

‎deps/v8/src/base/memcopy.h‎

Copy file name to clipboardExpand all lines: deps/v8/src/base/memcopy.h
+12-12Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -181,20 +181,20 @@ V8_INLINE void MemMove(void* dest, const void* src, size_t size) {
181181
}
182182

183183
#if V8_TARGET_BIG_ENDIAN
184-
inline void MemCopyAndSwitchEndianness(void* dst, void* src,
184+
inline void MemCopyAndSwitchEndianness(void* dst, const void* src,
185185
size_t num_elements,
186186
size_t element_size) {
187-
#define COPY_LOOP(type, reverse) \
188-
{ \
189-
for (uint32_t i = 0; i < num_elements; i++) { \
190-
type t; \
191-
type* s = reinterpret_cast<type*>(src) + i; \
192-
type* d = reinterpret_cast<type*>(dst) + i; \
193-
memcpy(&t, reinterpret_cast<void*>(s), element_size); \
194-
t = reverse(t); \
195-
memcpy(reinterpret_cast<void*>(d), &t, element_size); \
196-
} \
197-
return; \
187+
#define COPY_LOOP(type, reverse) \
188+
{ \
189+
for (uint32_t i = 0; i < num_elements; i++) { \
190+
type t; \
191+
const type* s = reinterpret_cast<const type*>(src) + i; \
192+
type* d = reinterpret_cast<type*>(dst) + i; \
193+
memcpy(&t, reinterpret_cast<const void*>(s), element_size); \
194+
t = reverse(t); \
195+
memcpy(reinterpret_cast<void*>(d), &t, element_size); \
196+
} \
197+
return; \
198198
}
199199

200200
switch (element_size) {
Collapse file

‎deps/v8/src/utils/memcopy.h‎

Copy file name to clipboardExpand all lines: deps/v8/src/utils/memcopy.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ inline void MemCopy(void* dest, const void* src, size_t size) {
3232
}
3333

3434
#if V8_TARGET_BIG_ENDIAN
35-
inline void MemCopyAndSwitchEndianness(void* dst, void* src,
35+
inline void MemCopyAndSwitchEndianness(void* dst, const void* src,
3636
size_t num_elements,
3737
size_t element_size) {
3838
v8::base::MemCopyAndSwitchEndianness(dst, src, num_elements, element_size);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.