Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c27f3cf

Browse filesBrowse files
ShogunPandaaduh95
authored andcommitted
build: add --enable-all-experimentals build flag
Signed-off-by: Paolo Insogna <paolo@cowtech.it> PR-URL: #62755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent e850ee9 commit c27f3cf
Copy full SHA for c27f3cf

3 files changed

+26-11Lines changed: 26 additions & 11 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
'python%': 'python',
1616

1717
'node_shared%': 'false',
18+
'node_enable_experimentals%': 'false',
1819
'force_dynamic_crt%': 0,
1920
'node_use_v8_platform%': 'true',
2021
'node_use_bundled_v8%': 'true',
@@ -437,6 +438,9 @@
437438
}],
438439
# The defines bellow must include all things from the external_v8_defines
439440
# list in v8/BUILD.gn.
441+
['node_enable_experimentals == "true"', {
442+
'defines': ['EXPERIMENTALS_DEFAULT_VALUE=true'],
443+
}],
440444
['v8_enable_v8_checks == 1', {
441445
'defines': ['V8_ENABLE_CHECKS'],
442446
}],
Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py
+7Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -797,6 +797,12 @@
797797
default=None,
798798
help='Enable the --trace-maps flag in V8 (use at your own risk)')
799799

800+
parser.add_argument('--enable-all-experimentals',
801+
action='store_true',
802+
dest='enable_all_experimentals',
803+
default=None,
804+
help='Enable all experimental features by default')
805+
800806
parser.add_argument('--experimental-enable-pointer-compression',
801807
action='store_true',
802808
dest='enable_pointer_compression',
@@ -1803,6 +1809,7 @@ def configure_node_cctest_sources(o):
18031809
def configure_node(o):
18041810
if options.dest_os == 'android':
18051811
o['variables']['OS'] = 'android'
1812+
o['variables']['node_enable_experimentals'] = b(options.enable_all_experimentals)
18061813
o['variables']['node_prefix'] = options.prefix
18071814
o['variables']['node_install_npm'] = b(not options.without_npm)
18081815
o['variables']['node_install_corepack'] = b(options.with_corepack)
Collapse file

‎src/node_options.h‎

Copy file name to clipboardExpand all lines: src/node_options.h
+15-11Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,10 @@ class DebugOptions : public Options {
112112
std::vector<std::string>* argv) override;
113113
};
114114

115+
#ifndef EXPERIMENTALS_DEFAULT_VALUE
116+
#define EXPERIMENTALS_DEFAULT_VALUE false
117+
#endif
118+
115119
class EnvironmentOptions : public Options {
116120
public:
117121
bool abort_on_uncaught_exception = false;
@@ -122,18 +126,18 @@ class EnvironmentOptions : public Options {
122126
bool require_module = true;
123127
std::string dns_result_order;
124128
bool enable_source_maps = false;
125-
bool experimental_addon_modules = false;
126-
bool experimental_eventsource = false;
127-
bool experimental_ffi = false;
129+
bool experimental_addon_modules = EXPERIMENTALS_DEFAULT_VALUE;
130+
bool experimental_eventsource = EXPERIMENTALS_DEFAULT_VALUE;
131+
bool experimental_ffi = EXPERIMENTALS_DEFAULT_VALUE;
128132
bool experimental_websocket = true;
129133
bool experimental_sqlite = HAVE_SQLITE;
130-
bool experimental_stream_iter = false;
134+
bool experimental_stream_iter = EXPERIMENTALS_DEFAULT_VALUE;
131135
bool webstorage = HAVE_SQLITE;
132-
bool experimental_quic = false;
136+
bool experimental_quic = EXPERIMENTALS_DEFAULT_VALUE;
133137
std::string localstorage_file;
134138
bool experimental_global_navigator = true;
135139
bool experimental_global_web_crypto = true;
136-
bool experimental_import_meta_resolve = false;
140+
bool experimental_import_meta_resolve = EXPERIMENTALS_DEFAULT_VALUE;
137141
std::string input_type; // Value of --input-type
138142
bool entry_is_url = false;
139143
bool permission = false;
@@ -148,7 +152,7 @@ class EnvironmentOptions : public Options {
148152
bool allow_ffi = false;
149153
bool allow_worker_threads = false;
150154
bool experimental_repl_await = true;
151-
bool experimental_vm_modules = false;
155+
bool experimental_vm_modules = EXPERIMENTALS_DEFAULT_VALUE;
152156
bool async_context_frame = true;
153157
bool expose_internals = false;
154158
bool force_node_api_uncaught_exceptions_policy = false;
@@ -175,10 +179,10 @@ class EnvironmentOptions : public Options {
175179
uint64_t cpu_prof_interval = kDefaultCpuProfInterval;
176180
std::string cpu_prof_name;
177181
bool cpu_prof = false;
178-
bool experimental_network_inspection = false;
179-
bool experimental_worker_inspection = false;
180-
bool experimental_storage_inspection = false;
181-
bool experimental_inspector_network_resource = false;
182+
bool experimental_network_inspection = EXPERIMENTALS_DEFAULT_VALUE;
183+
bool experimental_worker_inspection = EXPERIMENTALS_DEFAULT_VALUE;
184+
bool experimental_storage_inspection = EXPERIMENTALS_DEFAULT_VALUE;
185+
bool experimental_inspector_network_resource = EXPERIMENTALS_DEFAULT_VALUE;
182186
std::string heap_prof_dir;
183187
std::string heap_prof_name;
184188
static const uint64_t kDefaultHeapProfInterval = 512 * 1024;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.