Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c01ce60

Browse filesBrowse files
nodejs-github-botmarco-ippolito
authored andcommitted
deps: update googletest to 305e5a2
PR-URL: #53157 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 51e736a commit c01ce60
Copy full SHA for c01ce60

1 file changed

+6-6Lines changed: 6 additions & 6 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎deps/googletest/src/gtest.cc‎

Copy file name to clipboardExpand all lines: deps/googletest/src/gtest.cc
+6-6Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6700,17 +6700,17 @@ void ParseGoogleTestFlagsOnlyImpl(int* argc, CharType** argv) {
67006700
}
67016701

67026702
if (remove_flag) {
6703-
// Shift the remainder of the argv list left by one. Note
6704-
// that argv has (*argc + 1) elements, the last one always being
6705-
// NULL. The following loop moves the trailing NULL element as
6706-
// well.
6707-
for (int j = i; j != *argc; j++) {
6708-
argv[j] = argv[j + 1];
6703+
// Shift the remainder of the argv list left by one.
6704+
for (int j = i + 1; j < *argc; ++j) {
6705+
argv[j - 1] = argv[j];
67096706
}
67106707

67116708
// Decrements the argument count.
67126709
(*argc)--;
67136710

6711+
// Terminate the array with nullptr.
6712+
argv[*argc] = nullptr;
6713+
67146714
// We also need to decrement the iterator as we just removed
67156715
// an element.
67166716
i--;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.