Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit bef7b31

Browse filesBrowse files
StefanStojanovicRafaelGSS
StefanStojanovic
authored and
RafaelGSS
committed
deps: define V8_PRESERVE_MOST as no-op on Windows
It's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools Refs: #55784 PR-URL: #61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> (cherry picked from commit add506a)
1 parent a10bf1e commit bef7b31
Copy full SHA for bef7b31

2 files changed

+5-1Lines changed: 5 additions & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.1',
41+
'v8_embedder_string': '-node.2',
4242

4343
##### V8 defaults for Node.js #####
4444

Collapse file

‎deps/v8/include/v8config.h‎

Copy file name to clipboardExpand all lines: deps/v8/include/v8config.h
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -599,11 +599,15 @@ path. Add it with -I<path> to the command line
599599
// functions.
600600
// Use like:
601601
// V8_NOINLINE V8_PRESERVE_MOST void UnlikelyMethod();
602+
#if V8_OS_WIN
603+
# define V8_PRESERVE_MOST
604+
#else
602605
#if V8_HAS_ATTRIBUTE_PRESERVE_MOST
603606
# define V8_PRESERVE_MOST __attribute__((preserve_most))
604607
#else
605608
# define V8_PRESERVE_MOST /* NOT SUPPORTED */
606609
#endif
610+
#endif
607611

608612

609613
// A macro (V8_DEPRECATED) to mark classes or functions as deprecated.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.