Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b5cdc27

Browse filesBrowse files
MikeMcC399aduh95
authored andcommitted
build,win: improve logs when ClangCL is missing
PR-URL: #61438 Fixes: #61437 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent 0fb4642 commit b5cdc27
Copy full SHA for b5cdc27

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎vcbuild.bat‎

Copy file name to clipboardExpand all lines: vcbuild.bat
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ call :getnodeversion || exit /b 1
246246
set NODE_MAJOR_VERSION=
247247
for /F "tokens=1 delims=." %%i in ("%NODE_VERSION%") do set "NODE_MAJOR_VERSION=%%i"
248248
if %NODE_MAJOR_VERSION% GEQ 24 (
249-
echo Using ClangCL because the Node.js version being compiled is ^>= 24.
249+
echo ClangCL is required because the Node.js version being compiled is ^>= 24.
250250
set clang_cl=1
251251
)
252252

@@ -324,7 +324,7 @@ goto msbuild-found
324324

325325
:msbuild-not-found
326326
set "clang_echo="
327-
if defined clang_cl set "clang_echo= or Clang compiler/LLVM toolset"
327+
if defined clang_cl set "clang_echo= with Clang compiler/LLVM toolset"
328328
echo Failed to find a suitable Visual Studio installation%clang_echo%.
329329
echo Try to run in a "Developer Command Prompt" or consult
330330
echo https://github.com/nodejs/node/blob/HEAD/BUILDING.md#windows

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.