Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit add94f4

Browse filesBrowse files
deepak1556aduh95
authored andcommitted
build: track PDL files as inputs in inspector GN build
The `node_protocol_generated_sources` action was missing `gypi_values.node_pdl_files` from its inputs, causing Ninja to skip regeneration when PDL domain files changed. PR-URL: #62888 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
1 parent 7792f1a commit add94f4
Copy full SHA for add94f4

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/inspector/unofficial.gni‎

Copy file name to clipboardExpand all lines: src/inspector/unofficial.gni
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ template("inspector_gn_build") {
2929
deps = [ ":node_protocol_json" ]
3030

3131
outputs = gypi_values.node_inspector_generated_sources
32-
inputs = gypi_values.node_protocol_files + [
32+
inputs = gypi_values.node_protocol_files + gypi_values.node_pdl_files + [
3333
"node_protocol_config.json",
3434
"$node_gen_dir/src/node_protocol.json",
3535
]

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.