Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ad96a65

Browse filesBrowse files
aduh95richardlau
authored andcommitted
test: skip test-url on --shared-ada builds
PR-URL: #62019 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent e6b131f commit ad96a65
Copy full SHA for ad96a65

2 files changed

+7-6Lines changed: 7 additions & 6 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎shell.nix‎

Copy file name to clipboardExpand all lines: shell.nix
+1-6Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,7 @@ pkgs.mkShell {
107107
BUILD_WITH = if (ninja != null) then "ninja" else "make";
108108
NINJA = pkgs.lib.optionalString (ninja != null) "${pkgs.lib.getExe ninja}";
109109
CI_SKIP_TESTS = pkgs.lib.concatStringsSep "," (
110-
[ ]
111-
++ pkgs.lib.optionals useSharedAda [
112-
# Different versions of Ada affect the WPT tests
113-
"test-url"
114-
]
115-
++ pkgs.lib.optionals useSharedOpenSSL [
110+
pkgs.lib.optionals useSharedOpenSSL [
116111
# Path to the openssl.cnf is different from the expected one
117112
"test-strace-openat-openssl"
118113
]
Collapse file

‎test/wpt/test-url.js‎

Copy file name to clipboardExpand all lines: test/wpt/test-url.js
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
'use strict';
22

3+
const { skip } = require('../common');
4+
5+
if (process.config.variables.node_shared_ada) {
6+
skip('Different versions of Ada affect the WPT tests');
7+
}
8+
39
const { WPTRunner } = require('../common/wpt');
410

511
const runner = new WPTRunner('url');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.