File tree Expand file tree Collapse file tree
Open diff view settings
Expand file tree Collapse file tree
Open diff view settings
Original file line number Diff line number Diff line change 922922 },
923923 }],
924924 [ 'node_builtin_modules_path!=""' , {
925- 'defines' : [ 'NODE_BUILTIN_MODULES_PATH="<(node_builtin_modules_path)"' ]
925+ 'defines' : [ 'NODE_BUILTIN_MODULES_PATH="<(node_builtin_modules_path)"' ],
926+ # When loading builtins from disk, JS source files do not need to
927+ # trigger rebuilds since the binary reads them at runtime.
928+ 'sources!' : [
929+ '<@(library_files)' ,
930+ '<@(deps_files)' ,
931+ ],
926932 }],
927933 [ 'node_shared=="true"' , {
928934 'sources' : [
10671073 '<@(deps_files)' ,
10681074 'config.gypi'
10691075 ],
1076+ 'conditions' : [
1077+ [ 'node_builtin_modules_path!=""' , {
1078+ # When loading builtins from disk, JS source files do not need
1079+ # to trigger rebuilds since the binary reads them at runtime.
1080+ 'inputs!' : [
1081+ '<@(library_files)' ,
1082+ '<@(deps_files)' ,
1083+ ],
1084+ }],
1085+ ],
10701086 'outputs' : [
10711087 '<(SHARED_INTERMEDIATE_DIR)/node_javascript.cc' ,
10721088 ],
Original file line number Diff line number Diff line change @@ -72,7 +72,8 @@ const BuiltinSource* BuiltinLoader::AddFromDisk(const char* id,
7272 const std::string& filename,
7373 const UnionBytes& source) {
7474 BuiltinSourceType type = GetBuiltinSourceType (id, filename);
75- auto result = source_.write ()->emplace (id, BuiltinSource{id, source, type});
75+ auto result =
76+ source_.write ()->insert_or_assign (id, BuiltinSource{id, source, type});
7677 return &(result.first ->second );
7778}
7879
You can’t perform that action at this time.
0 commit comments