Commit a8b32b8
test: fix race condition in watch mode tests
The watch mode tests using runInBackground() had a race condition where
stdout "Failed running" message could arrive before stderr was fully
collected, causing assertions on stderr content to fail with empty
strings.
Fix by waiting for stderr 'data' event if stderr is empty when "Failed
running" is detected. This is an event-driven approach rather than
timing-based.
Refs: nodejs/reliability#1450
PR-URL: #61615
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 086a5a5 commit a8b32b8Copy full SHA for a8b32b8
2 files changed
+33-12Lines changed: 33 additions & 12 deletions
File tree
Expand file treeCollapse file tree
Open diff view settings
Filter options
- test/sequential
Expand file treeCollapse file tree
Open diff view settings
Collapse file
test/sequential/test-watch-mode-restart-esm-loading-error.mjs
Copy file name to clipboardExpand all lines: test/sequential/test-watch-mode-restart-esm-loading-error.mjs+18-6Lines changed: 18 additions & 6 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
11 | 11 | |
12 | 12 | |
13 | 13 | |
| 14 | + |
| 15 | + |
| 16 | + |
14 | 17 | |
15 | 18 | |
16 | 19 | |
| ||
42 | 45 | |
43 | 46 | |
44 | 47 | |
45 | | - |
46 | | - |
| 48 | + |
| 49 | + |
| 50 | + |
| 51 | + |
| 52 | + |
| 53 | + |
| 54 | + |
| 55 | + |
| 56 | + |
| 57 | + |
| 58 | + |
| 59 | + |
| 60 | + |
| 61 | + |
47 | 62 | |
48 | | - |
| 63 | + |
49 | 64 | |
50 | | - |
51 | | - |
52 | | - |
53 | 65 | |
54 | 66 | |
55 | 67 | |
|
Collapse file
test/sequential/test-watch-mode.mjs
Copy file name to clipboardExpand all lines: test/sequential/test-watch-mode.mjs+15-6Lines changed: 15 additions & 6 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
54 | 54 | |
55 | 55 | |
56 | 56 | |
57 | | - |
58 | | - |
| 57 | + |
| 58 | + |
| 59 | + |
| 60 | + |
| 61 | + |
| 62 | + |
| 63 | + |
| 64 | + |
| 65 | + |
| 66 | + |
| 67 | + |
| 68 | + |
| 69 | + |
| 70 | + |
59 | 71 | |
60 | | - |
| 72 | + |
61 | 73 | |
62 | | - |
63 | | - |
64 | | - |
65 | 74 | |
66 | 75 | |
67 | 76 | |
|
0 commit comments