Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 931d02f

Browse filesBrowse files
nicolo-ribaudorichardlau
nicolo-ribaudo
authored and
richardlau
committed
test, v8: fix wrong import attributes test
PR-URL: #52184 Refs: #51136 Refs: #52165 (comment) Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
1 parent 812b126 commit 931d02f
Copy full SHA for 931d02f
Expand file treeCollapse file tree

6 files changed

+10
-4
lines changed
Open diff view settings
Collapse file

‎deps/v8/test/mjsunit/harmony/modules-import-assertions-3.mjs‎

Copy file name to clipboardExpand all lines: deps/v8/test/mjsunit/harmony/modules-import-assertions-3.mjs
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44

55
// Flags: --harmony-import-assertions
66

7-
import {life} from 'modules-skip-imports-json-1.mjs';
7+
import {life} from 'modules-skip-imports-json-assert-1.mjs';
88

99
assertEquals(42, life());
Collapse file

‎deps/v8/test/mjsunit/harmony/modules-import-assertions-dynamic-5.mjs‎

Copy file name to clipboardExpand all lines: deps/v8/test/mjsunit/harmony/modules-import-assertions-dynamic-5.mjs
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// Flags: --allow-natives-syntax --harmony-import-assertions
66

77
var life;
8-
import('modules-skip-imports-json-1.mjs',).then(namespace => life = namespace.life());
8+
import('modules-skip-imports-json-assert-1.mjs',).then(namespace => life = namespace.life());
99

1010
%PerformMicrotaskCheckpoint();
1111

Collapse file

‎deps/v8/test/mjsunit/harmony/modules-import-attributes-3.mjs‎

Copy file name to clipboardExpand all lines: deps/v8/test/mjsunit/harmony/modules-import-attributes-3.mjs
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44

55
// Flags: --harmony-import-attributes
66

7-
import {life} from 'modules-skip-imports-json-1.mjs';
7+
import {life} from 'modules-skip-imports-json-with-1.mjs';
88

99
assertEquals(42, life());
Collapse file

‎deps/v8/test/mjsunit/harmony/modules-import-attributes-dynamic-5.mjs‎

Copy file name to clipboardExpand all lines: deps/v8/test/mjsunit/harmony/modules-import-attributes-dynamic-5.mjs
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// Flags: --allow-natives-syntax --harmony-import-attributes
66

77
var life;
8-
import('modules-skip-imports-json-1.mjs',).then(namespace => life = namespace.life());
8+
import('modules-skip-imports-json-with-1.mjs',).then(namespace => life = namespace.life());
99

1010
%PerformMicrotaskCheckpoint();
1111

Collapse file

‎…/harmony/modules-skip-imports-json-1.mjs‎ ‎…y/modules-skip-imports-json-assert-1.mjs‎deps/v8/test/mjsunit/harmony/modules-skip-imports-json-1.mjs renamed to deps/v8/test/mjsunit/harmony/modules-skip-imports-json-assert-1.mjs deps/v8/test/mjsunit/harmony/modules-skip-imports-json-1.mjs renamed to deps/v8/test/mjsunit/harmony/modules-skip-imports-json-assert-1.mjs

Copy file name to clipboard
File renamed without changes.
Collapse file

‎deps/v8/test/mjsunit/harmony/modules-skip-imports-json-with-1.mjs‎

Copy file name to clipboard
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
// Copyright 2021 the V8 project authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
import json from "modules-skip-1.json" with { type: "json" };
6+
export function life() { return json.life; }

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.