Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7efc2ce

Browse filesBrowse files
committed
src: clean up experimental flag variables
- `fetch` is no longer disable by a CLI flag - `node:sqlite` requires SQLite, obviously Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #62759 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 78c7d77 commit 7efc2ce
Copy full SHA for 7efc2ce

4 files changed

+5-9Lines changed: 5 additions & 9 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/api/environment.cc‎

Copy file name to clipboardExpand all lines: src/api/environment.cc
+2-6Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -267,13 +267,9 @@ void SetIsolateMiscHandlers(v8::Isolate* isolate, const IsolateSettings& s) {
267267
isolate->SetModifyCodeGenerationFromStringsCallback(
268268
modify_code_generation_from_strings_callback);
269269

270-
Mutex::ScopedLock lock(node::per_process::cli_options_mutex);
271-
if (per_process::cli_options->get_per_isolate_options()
272-
->get_per_env_options()
273-
->experimental_fetch) {
274-
isolate->SetWasmStreamingCallback(wasm_web_api::StartStreamingCompilation);
275-
}
270+
isolate->SetWasmStreamingCallback(wasm_web_api::StartStreamingCompilation);
276271

272+
Mutex::ScopedLock lock(node::per_process::cli_options_mutex);
277273
if (per_process::cli_options->get_per_isolate_options()
278274
->experimental_shadow_realm) {
279275
isolate->SetHostCreateShadowRealmContextCallback(
Collapse file

‎src/node_options.cc‎

Copy file name to clipboardExpand all lines: src/node_options.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
605605
"experimental node:sqlite module",
606606
&EnvironmentOptions::experimental_sqlite,
607607
kAllowedInEnvvar,
608-
true);
608+
HAVE_SQLITE);
609609
AddOption("--experimental-stream-iter",
610610
"experimental iterable streams API (node:stream/iter)",
611611
&EnvironmentOptions::experimental_stream_iter,
Collapse file

‎src/node_options.h‎

Copy file name to clipboardExpand all lines: src/node_options.h
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,9 @@ class EnvironmentOptions : public Options {
124124
bool enable_source_maps = false;
125125
bool experimental_addon_modules = false;
126126
bool experimental_eventsource = false;
127-
bool experimental_fetch = true;
128127
bool experimental_ffi = false;
129128
bool experimental_websocket = true;
130-
bool experimental_sqlite = true;
129+
bool experimental_sqlite = HAVE_SQLITE;
131130
bool experimental_stream_iter = false;
132131
bool webstorage = HAVE_SQLITE;
133132
bool experimental_quic = false;
Collapse file

‎test/parallel/test-require-resolve.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-require-resolve.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ require(fixtures.path('resolve-paths', 'default', 'verify-paths.js'));
6464
if (mod === 'node:quic') return;
6565
// TODO: Remove once node:ffi is no longer flagged
6666
if (mod === 'node:ffi') return;
67+
if (mod === 'node:sqlite' && !common.hasSQLite) return;
6768
assert.strictEqual(require.resolve.paths(mod), null);
6869
if (!mod.startsWith('node:')) {
6970
assert.strictEqual(require.resolve.paths(`node:${mod}`), null);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.