Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6cf9b57

Browse filesBrowse files
aduh95marco-ippolito
authored andcommitted
tools: enforce removal of lts-watch-* labels on release proposals
PR-URL: #61672 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
1 parent cd41614 commit 6cf9b57
Copy full SHA for 6cf9b57

1 file changed

+8-2Lines changed: 8 additions & 2 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎.github/workflows/lint-release-proposal.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/lint-release-proposal.yml
+8-2Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,15 @@ jobs:
9292
"/repos/${GITHUB_REPOSITORY}/compare/v${MAJOR}.x...$GITHUB_SHA" --paginate \
9393
| node tools/actions/lint-release-proposal-commit-list.mjs "$CHANGELOG_PATH" "$GITHUB_SHA" \
9494
| while IFS= read -r PR_URL; do
95-
LABEL="dont-land-on-v${MAJOR}.x" gh pr view \
95+
DONT_LAND_LABEL="dont-land-on-v${MAJOR}.x" LTS_WATCH_LABEL="lts-watch-v${MAJOR}.x" gh pr view \
9696
--json labels,url \
97-
--jq 'if (.labels|map(.name==env.LABEL)|any) then error("\(.url) has the \(env.LABEL) label, forbidding it to be in this release proposal") end' \
97+
--jq '
98+
if (.labels|any(.name==env.DONT_LAND_LABEL)) then
99+
error("\(.url) has the \(env.DONT_LAND_LABEL) label, forbidding it to be in this release proposal")
100+
elif (.labels|any(.name==env.LTS_WATCH_LABEL)) then
101+
error("\(.url) has the \(env.LTS_WATCH_LABEL) label, please remove the label now that the PR is included in a release proposal")
102+
end
103+
' \
98104
"$PR_URL" > /dev/null
99105
done
100106
shell: bash # See https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference, we want the pipefail option.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.