Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4157964

Browse filesBrowse files
committed
deps: remove problematic comment from v8-internal
GCC emits warnings because of the trailing backslashes. PR-URL: #58070 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent ecca2b0 commit 4157964
Copy full SHA for 4157964

2 files changed

+1-14Lines changed: 1 addition & 14 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.2',
41+
'v8_embedder_string': '-node.3',
4242

4343
##### V8 defaults for Node.js #####
4444

Collapse file

‎deps/v8/include/v8-internal.h‎

Copy file name to clipboardExpand all lines: deps/v8/include/v8-internal.h
-13Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -425,19 +425,6 @@ constexpr size_t kMaxCppHeapPointers = 0;
425425
// which all subtypes of a given supertype use contiguous tags. This struct can
426426
// then be used to represent such a type range.
427427
//
428-
// As an example, consider the following type hierarchy:
429-
//
430-
// A F
431-
// / \
432-
// B E
433-
// / \
434-
// C D
435-
//
436-
// A potential type id assignment for range-based type checks is
437-
// {A: 0, B: 1, C: 2, D: 3, E: 4, F: 5}. With that, the type check for type A
438-
// would check for the range [A, E], while the check for B would check range
439-
// [B, D], and for F it would simply check [F, F].
440-
//
441428
// In addition, there is an option for performance tweaks: if the size of the
442429
// type range corresponding to a supertype is a power of two and starts at a
443430
// power of two (e.g. [0x100, 0x13f]), then the compiler can often optimize

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.