Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 412252c

Browse filesBrowse files
geekrvagg
authored andcommitted
util: Remove p, has been deprecated for years
Update deprecation test to use another method. Ref: #2529 PR-URL: #3432 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
1 parent b607366 commit 412252c
Copy full SHA for 412252c

File tree

Expand file treeCollapse file tree

3 files changed

+6
-13
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+6
-13
lines changed
Open diff view settings
Collapse file

‎lib/util.js‎

Copy file name to clipboardExpand all lines: lib/util.js
-7Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -790,13 +790,6 @@ function hasOwnProperty(obj, prop) {
790790

791791
// Deprecated old stuff.
792792

793-
exports.p = internalUtil.deprecate(function() {
794-
for (var i = 0, len = arguments.length; i < len; ++i) {
795-
console.error(exports.inspect(arguments[i]));
796-
}
797-
}, 'util.p is deprecated. Use console.error instead.');
798-
799-
800793
exports.exec = internalUtil.deprecate(function() {
801794
return require('child_process').exec.apply(this, arguments);
802795
}, 'util.exec is deprecated. Use child_process.exec instead.');
Collapse file

‎test/fixtures/deprecated.js‎

Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
require('util').p('This is deprecated');
1+
require('util').debug('This is deprecated');
Collapse file

‎test/sequential/test-deprecation-flags.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-deprecation-flags.js
+5-5Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,16 @@ execFile(node, normal, function(er, stdout, stderr) {
1616
console.error('normal: show deprecation warning');
1717
assert.equal(er, null);
1818
assert.equal(stdout, '');
19-
assert.equal(stderr, '(node) util.p is deprecated. Use console.error ' +
20-
'instead.\n\'This is deprecated\'\n');
19+
assert.equal(stderr, '(node) util.debug is deprecated. Use console.error ' +
20+
'instead.\nDEBUG: This is deprecated\n');
2121
console.log('normal ok');
2222
});
2323

2424
execFile(node, noDep, function(er, stdout, stderr) {
2525
console.error('--no-deprecation: silence deprecations');
2626
assert.equal(er, null);
2727
assert.equal(stdout, '');
28-
assert.equal(stderr, '\'This is deprecated\'\n');
28+
assert.equal(stderr, 'DEBUG: This is deprecated\n');
2929
console.log('silent ok');
3030
});
3131

@@ -36,8 +36,8 @@ execFile(node, traceDep, function(er, stdout, stderr) {
3636
var stack = stderr.trim().split('\n');
3737
// just check the top and bottom.
3838
assert.equal(stack[0],
39-
'Trace: util.p is deprecated. Use console.error instead.');
40-
assert.equal(stack.pop(), '\'This is deprecated\'');
39+
'Trace: util.debug is deprecated. Use console.error instead.');
40+
assert.equal(stack.pop(), 'DEBUG: This is deprecated');
4141
console.log('trace ok');
4242
});
4343

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.