util: Remove p, has been deprecated for years #2529
Conversation
|
Adding this to the list of things to check. |
|
+1, FWIW, here's the deprecation commit from five years ago: 022c083 |
|
I think it's definitely safe to remove something deprecated in |
|
LGTM |
|
@chrisdickinson update? |
|
Still working on the tool to check. It's coming along, but I'm not sure there should be a rush to remove this? |
|
(OTOH, it's really unlikely that removing |
|
For the record, |
|
TSC agreed to remove |
|
Added to the 5.0.0 milestone. |
|
LGTM |
|
LGTM. |
|
Quick grep results for deck-node-1.0.11.tgz/typed/async/async-tests.ts:185: function () { sys.p('one'); },
deck-node-1.0.11.tgz/typed/async/async-tests.ts:186: function () { sys.p('two'); },
deck-node-1.0.11.tgz/typed/async/async-tests.ts:187: function () { sys.p('three'); }
definitively-typed-0.0.1.tgz/async/async-tests.ts:243: function () { sys.p('one'); },
definitively-typed-0.0.1.tgz/async/async-tests.ts:244: function () { sys.p('two'); },
definitively-typed-0.0.1.tgz/async/async-tests.ts:245: function () { sys.p('three'); }
mysql-native-prerelease-1.4.2.tgz/examples/myhttp.js:8:process.addListener('uncaughtException', function(err) { sys.p(err); });
mysql-native-prerelease-1.4.2.tgz/examples/myhttp.js:40: sys.p(q);
mysql-native-prerelease-1.4.2.tgz/tests/test_execute.js:11:examplecmd.on('error', function(s) { sys.p(s); } );
mysql-native-prerelease-1.4.2.tgz/tests/test_stress.js:9:sys.p(numclients);
noblerecord-v1.0.1.tgz/src/mysql.js:154: sys.p(me.connection.connectError);
restler-aaronblohowiak-0.0.2.tgz/test/multipartform.js:37: sys.p(bytesWritten);
restler-aaronblohowiak-0.0.2.tgz/test/multipartform.js:72: sys.p("closing and sending");
shoutcast-0.0.2.tgz/lib/file.js:23: sys.p(erro);
webidl.js-0.1.0.tgz/scratch/test.js:22: sys.p(e);LGTM |
|
CI before landing: https://ci.nodejs.org/job/node-test-commit/861/ |
|
@geek this breaks a test. Do you have time to fix it ? |
Update deprecation test to use another method. Ref: nodejs#2529 PR-URL: nodejs#3432 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Landed in 8b4adb2. |
This function has been deprecated for years... it's not documented either, so should fall under the implicit API deprecation policy:
https://github.com/joyent/node/blob/v0.8.28-release/lib/util.js#L450-L454