Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 364d09c

Browse filesBrowse files
Trottmarco-ippolito
authored andcommitted
test: add comments and rename test for timer robustness
The name of the test did not make it clear what it was about. (It also used "timer" in the name instead of "timers" like all the other tests.) I also added a comment to be extra clear about the test purpose and a link to the issue that was originally filed about it. PR-URL: #54008 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
1 parent 5c5093d commit 364d09c
Copy full SHA for 364d09c

1 file changed

+3Lines changed: 3 additions & 0 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎test/parallel/test-timer-immediate.js‎ ‎…arallel/test-timers-process-tampering.js‎test/parallel/test-timer-immediate.js renamed to test/parallel/test-timers-process-tampering.js test/parallel/test-timer-immediate.js renamed to test/parallel/test-timers-process-tampering.js

Copy file name to clipboardExpand all lines: test/parallel/test-timers-process-tampering.js
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Check that setImmediate works even if process is tampered with.
2+
// This is a regression test for https://github.com/nodejs/node/issues/17681.
3+
14
'use strict';
25
const common = require('../common');
36
global.process = {}; // Boom!

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.