Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2dc1d20

Browse filesBrowse files
gahaasaduh95
authored andcommitted
src: replace uses of deprecated v8::External APIs
PR-URL: #61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent 7a86108 commit 2dc1d20
Copy full SHA for 2dc1d20

1 file changed

+4-3Lines changed: 4 additions & 3 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/node_ffi.cc‎

Copy file name to clipboardExpand all lines: src/node_ffi.cc
+4-3Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,8 @@ MaybeLocal<Function> DynamicLibrary::CreateFunction(
191191

192192
FFIFunctionInfo* info = new FFIFunctionInfo();
193193
info->fn = fn;
194-
Local<External> data = External::New(isolate, info);
194+
Local<External> data =
195+
External::New(isolate, info, v8::kExternalPointerTypeTagDefault);
195196
MaybeLocal<Function> maybe_ret =
196197
Function::New(env->context(), DynamicLibrary::InvokeFunction, data);
197198
Local<Function> ret;
@@ -274,8 +275,8 @@ void DynamicLibrary::Close(const FunctionCallbackInfo<Value>& args) {
274275

275276
void DynamicLibrary::InvokeFunction(const FunctionCallbackInfo<Value>& args) {
276277
Environment* env = Environment::GetCurrent(args);
277-
FFIFunctionInfo* info =
278-
static_cast<FFIFunctionInfo*>(args.Data().As<External>()->Value());
278+
FFIFunctionInfo* info = static_cast<FFIFunctionInfo*>(
279+
args.Data().As<External>()->Value(v8::kExternalPointerTypeTagDefault));
279280
FFIFunction* fn = info->fn.get();
280281

281282
if (fn == nullptr || fn->closed || fn->ptr == nullptr) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.