Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2b12bca

Browse filesBrowse files
Renegade334aduh95
authored andcommitted
src: use context-free V8 message column getters
PR-URL: #62778 Refs: https://issues.chromium.org/issues/42210793 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
1 parent f454d17 commit 2b12bca
Copy full SHA for 2b12bca

2 files changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/inspector_agent.cc‎

Copy file name to clipboardExpand all lines: src/inspector_agent.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -677,7 +677,7 @@ class NodeInspectorClient : public V8InspectorClient {
677677
ToInspectorString(isolate, message->Get())->string(),
678678
ToInspectorString(isolate, message->GetScriptResourceName())->string(),
679679
message->GetLineNumber(context).FromMaybe(0),
680-
message->GetStartColumn(context).FromMaybe(0),
680+
message->GetStartColumn(),
681681
client_->createStackTrace(stack_trace),
682682
script_id);
683683
}
Collapse file

‎src/node_errors.cc‎

Copy file name to clipboardExpand all lines: src/node_errors.cc
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ static std::string GetSourceMapErrorSource(Isolate* isolate,
6565
// the source texts.
6666
Local<Value> script_resource_name = message->GetScriptResourceName();
6767
int linenum = message->GetLineNumber(context).FromJust();
68-
int columnum = message->GetStartColumn(context).FromJust();
68+
int columnum = message->GetStartColumn();
6969

7070
Local<Value> argv[] = {script_resource_name,
7171
v8::Int32::New(isolate, linenum),
@@ -148,8 +148,8 @@ static std::string GetErrorSource(Isolate* isolate,
148148
int script_start = (linenum - origin.LineOffset()) == 1
149149
? origin.ColumnOffset()
150150
: 0;
151-
int start = message->GetStartColumn(context).FromMaybe(0);
152-
int end = message->GetEndColumn(context).FromMaybe(0);
151+
int start = message->GetStartColumn();
152+
int end = message->GetEndColumn();
153153
if (start >= script_start) {
154154
CHECK_GE(end, start);
155155
start -= script_start;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.