nodejs
diff --git a/Collapse file
‎deps/googletest/include/gtest/internal/gtest-port.h‎
Copy file name to clipboardExpand all lines: deps/googletest/include/gtest/internal/gtest-port.h
+2-2Lines changed: 2 additions & 2 deletions b/Collapse file
‎deps/googletest/include/gtest/internal/gtest-port.h‎
Copy file name to clipboardExpand all lines: deps/googletest/include/gtest/internal/gtest-port.h
+2-2Lines changed: 2 additions & 2 deletions
diff --git a/Collapse file
‎deps/googletest/src/gtest-port.cc‎
Copy file name to clipboardExpand all lines: deps/googletest/src/gtest-port.cc
+7-6Lines changed: 7 additions & 6 deletions b/Collapse file
‎deps/googletest/src/gtest-port.cc‎
Copy file name to clipboardExpand all lines: deps/googletest/src/gtest-port.cc
+7-6Lines changed: 7 additions & 6 deletions
@@ -1515,13 +1515,13 @@ class [[nodiscard]] ThreadWithParam : public ThreadWithParamBase {
 
   ThreadWithParam(UserThreadFunc* func, T param, Notification* thread_can_start)
       : ThreadWithParamBase(new RunnableImpl(func, param), thread_can_start) {}
-  ~ThreadWithParam() override {}
+  ~ThreadWithParam() override = default;
 
  private:
   class RunnableImpl : public Runnable {
    public:
     RunnableImpl(UserThreadFunc* func, T param) : func_(func), param_(param) {}
-    ~RunnableImpl() override {}
+    ~RunnableImpl() override = default;
     void Run() override { func_(param_); }
 
    private:
 
@@ -89,6 +89,7 @@
 
 #include "gtest/gtest-message.h"
 #include "gtest/gtest-spi.h"
+#include "gtest/gtest.h"
 #include "gtest/internal/gtest-internal.h"
 #include "gtest/internal/gtest-string.h"
 #include "src/gtest-internal-inl.h"
@@ -729,7 +730,7 @@ void RE::Init(const char* regex) {
   char* const full_pattern = new char[full_regex_len];
 
   snprintf(full_pattern, full_regex_len, "^(%s)$", regex);
-  is_valid_ = regcomp(&full_regex_, full_pattern, reg_flags) == 0;
+  int error = regcomp(&full_regex_, full_pattern, reg_flags);
   // We want to call regcomp(&partial_regex_, ...) even if the
   // previous expression returns false.  Otherwise partial_regex_ may
   // not be properly initialized can may cause trouble when it's
@@ -738,13 +739,13 @@ void RE::Init(const char* regex) {
   // Some implementation of POSIX regex (e.g. on at least some
   // versions of Cygwin) doesn't accept the empty string as a valid
   // regex.  We change it to an equivalent form "()" to be safe.
-  if (is_valid_) {
+  if (!error) {
     const char* const partial_regex = (*regex == '\0') ? "()" : regex;
-    is_valid_ = regcomp(&partial_regex_, partial_regex, reg_flags) == 0;
+    error = regcomp(&partial_regex_, partial_regex, reg_flags);
   }
-  EXPECT_TRUE(is_valid_)
-      << "Regular expression \"" << regex
-      << "\" is not a valid POSIX Extended regular expression.";
+  is_valid_ = error == 0;
+  EXPECT_EQ(error, 0) << "Regular expression \"" << regex
+                      << "\" is not a valid POSIX Extended regular expression.";
 
   delete[] full_pattern;
 }