Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 240b512

Browse filesBrowse files
mcollinaaduh95
authored andcommitted
doc: clarify build environment is trusted in threat model
Add build system attacks (command injection via environment variables, path hijacking, file permissions) to the list of non-vulnerabilities. The build environment is a trusted element and these scenarios require an already-compromised system. PR-URL: #61865 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent 837acd7 commit 240b512
Copy full SHA for 240b512

1 file changed

+15Lines changed: 15 additions & 0 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎SECURITY.md‎

Copy file name to clipboardExpand all lines: SECURITY.md
+15Lines changed: 15 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,21 @@ the community they pose.
335335
proper security boundaries between trusted application logic and untrusted
336336
user input.
337337

338+
#### Build System Attacks Requiring Control of the Build Environment (CWE-78, CWE-114, CWE-276)
339+
340+
* The Node.js build system (e.g., `configure`, `configure.py`, `Makefile`,
341+
`vcbuild.bat`) is designed to run in a trusted build environment.
342+
The build environment, including environment variables, the file system,
343+
and locally installed tools, is a trusted element in the Node.js threat model.
344+
* Reports about command injection via environment variables in build scripts
345+
(e.g., `CC`, `CXX`, `PKG_CONFIG`, `RUSTC`), path hijacking in build output
346+
directories, or file permissions of build artifacts are **not** considered
347+
vulnerabilities. These scenarios require the attacker to already have control
348+
over the build environment, which means the system is already compromised.
349+
* Build scripts are not a security boundary. They are expected to execute
350+
tools and scripts specified by the environment, and to trust the
351+
file system they operate on.
352+
338353
#### Unhandled 'error' Events on EventEmitters (CWE-248)
339354

340355
* EventEmitters that can emit `'error'` events require the application to

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.