Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 1abada9

Browse filesBrowse files
aduh95aduh95
committed
tools: avoid building twice in coverage jobs
PR-URL: #61899 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent f260e40 commit 1abada9
Copy full SHA for 1abada9

2 files changed

+6-6Lines changed: 6 additions & 6 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎.github/workflows/coverage-linux-without-intl.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/coverage-linux-without-intl.yml
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,11 @@ jobs:
6565
run: npx envinfo
6666
- name: Install gcovr
6767
run: pip install gcovr==7.2
68-
- name: Build
69-
run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --coverage --without-intl"
68+
- name: Configure
69+
run: ./configure --verbose --error-on-warn --coverage --without-intl
7070
# TODO(bcoe): fix the couple tests that fail with the inspector enabled.
7171
# The cause is most likely coverage's use of the inspector.
72-
- name: Test
72+
- name: Build and test
7373
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9" || exit 0
7474
- name: Report JS
7575
run: npx c8 report --check-coverage
Collapse file

‎.github/workflows/coverage-linux.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/coverage-linux.yml
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,11 @@ jobs:
6565
run: npx envinfo
6666
- name: Install gcovr
6767
run: pip install gcovr==7.2
68-
- name: Build
69-
run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --coverage"
68+
- name: Configure
69+
run: ./configure --verbose --error-on-warn --coverage
7070
# TODO(bcoe): fix the couple tests that fail with the inspector enabled.
7171
# The cause is most likely coverage's use of the inspector.
72-
- name: Test
72+
- name: Build and test
7373
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9" || exit 0
7474
- name: Report JS
7575
run: npx c8 report --check-coverage

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.