Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 193d629

Browse filesBrowse files
Xstoudiaduh95
authored andcommitted
doc: test and test-only targets do not run linter
`make test` and `make test-only` targets no longer runs linters. This commit updates the inline comments and building doc to reflect reality. Fixes: #58606 PR-URL: #62120 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
1 parent 064f7c2 commit 193d629
Copy full SHA for 193d629

2 files changed

+4-6Lines changed: 4 additions & 6 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎BUILDING.md‎

Copy file name to clipboardExpand all lines: BUILDING.md
+2-4Lines changed: 2 additions & 4 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -403,11 +403,9 @@ If you are running tests before submitting a pull request, use:
403403
make -j4 test
404404
```
405405

406-
`make -j4 test` does a full check on the codebase, including running linters and
407-
documentation tests.
406+
`make -j4 test` does a full check on the codebase, including documentation tests.
408407

409-
To run the linter without running tests, use
410-
`make lint`/`vcbuild lint`. It will lint JavaScript, C++, and Markdown files.
408+
To run the linter, use `make lint`/`vcbuild lint`. It will lint JavaScript, C++, and Markdown files.
411409

412410
To fix auto fixable JavaScript linting errors, use `make lint-js-fix`.
413411

Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ coverage-run-js: ## Run JavaScript tests with coverage.
338338

339339
.PHONY: test
340340
# This does not run tests of third-party libraries inside deps.
341-
test: all ## Run default tests, linters, and build docs.
341+
test: all ## Run default tests and build docs.
342342
$(MAKE) -s tooltest
343343
$(MAKE) -s build-addons
344344
$(MAKE) -s build-js-native-api-tests
@@ -348,7 +348,7 @@ test: all ## Run default tests, linters, and build docs.
348348
$(MAKE) -s jstest
349349

350350
.PHONY: test-only
351-
test-only: all ## Run default tests, without linters or building the docs.
351+
test-only: all ## Run default tests without building the docs.
352352
$(MAKE) build-addons
353353
$(MAKE) build-js-native-api-tests
354354
$(MAKE) build-node-api-tests

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.