Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 12faf04

Browse filesBrowse files
kmk324ruyadorno
authored andcommitted
build: fix make errors that occur in Makefile
fix make errors that occur in coverage-clean case and coverage-test in Makefile PR-URL: #55287 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 23d89da commit 12faf04
Copy full SHA for 12faf04

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ coverage-clean: ## Remove coverage artifacts.
243243
$(RM) -r coverage/tmp
244244
@if [ -d "out/Release/obj.target" ]; then \
245245
$(FIND) out/$(BUILDTYPE)/obj.target \( -name "*.gcda" -o -name "*.gcno" \) \
246-
-type f -exec $(RM) {};\
246+
-type f | xargs $(RM); \
247247
fi
248248

249249
.PHONY: coverage
@@ -269,7 +269,7 @@ coverage-build-js: ## Build JavaScript coverage files.
269269
.PHONY: coverage-test
270270
coverage-test: coverage-build ## Run the tests and generate a coverage report.
271271
@if [ -d "out/Release/obj.target" ]; then \
272-
$(FIND) out/$(BUILDTYPE)/obj.target -name "*.gcda" -type f -exec $(RM) {}; \
272+
$(FIND) out/$(BUILDTYPE)/obj.target -name "*.gcda" -type f | xargs $(RM); \
273273
fi
274274
-NODE_V8_COVERAGE=coverage/tmp \
275275
TEST_CI_ARGS="$(TEST_CI_ARGS) --type=coverage" $(MAKE) $(COVTESTS)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.