Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0ac87c2

Browse filesBrowse files
LekoMylesBorins
authored andcommitted
test: replace assert.throws with common.expectsError
PR-URL: #17445 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent cd7cee5 commit 0ac87c2
Copy full SHA for 0ac87c2

File tree

Expand file treeCollapse file tree

1 file changed

+9
-12
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+9
-12
lines changed
Open diff view settings
Collapse file

‎test/addons-napi/test_error/test.js‎

Copy file name to clipboardExpand all lines: test/addons-napi/test_error/test.js
+9-12Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -60,29 +60,26 @@ assert.throws(() => {
6060
test_error.throwTypeError();
6161
}, /^TypeError: type error$/);
6262

63-
assert.throws(
63+
common.expectsError(
6464
() => test_error.throwErrorCode(),
65-
common.expectsError({
65+
{
6666
code: 'ERR_TEST_CODE',
6767
message: 'Error [error]'
68-
})
69-
);
68+
});
7069

71-
assert.throws(
70+
common.expectsError(
7271
() => test_error.throwRangeErrorCode(),
73-
common.expectsError({
72+
{
7473
code: 'ERR_TEST_CODE',
7574
message: 'RangeError [range error]'
76-
})
77-
);
75+
});
7876

79-
assert.throws(
77+
common.expectsError(
8078
() => test_error.throwTypeErrorCode(),
81-
common.expectsError({
79+
{
8280
code: 'ERR_TEST_CODE',
8381
message: 'TypeError [type error]'
84-
})
85-
);
82+
});
8683

8784
let error = test_error.createError();
8885
assert.ok(error instanceof Error, 'expected error to be an instance of Error');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.