Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

test: replace assert.throws with common.expectsError #17445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Leko wants to merge 1 commit into from
Closed

test: replace assert.throws with common.expectsError #17445

Leko wants to merge 1 commit into from

Conversation

@Leko
Copy link
Contributor

@Leko Leko commented Dec 4, 2017

Replace assert.throws(fn, common.expectsError(err)); with common.expectsError(fn, err); in test/addons-napi/test_error/test.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Dec 4, 2017
@lpinca
Copy link
Member

lpinca commented Dec 4, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/11863/
CI: https://ci.nodejs.org/job/node-test-pull-request/11865/

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2017
@maclover7 maclover7 self-assigned this Dec 5, 2017
@maclover7
Copy link
Contributor

maclover7 commented Dec 6, 2017

Landing...

@maclover7
Copy link
Contributor

maclover7 commented Dec 6, 2017

Thank you for your contribution, landed in 50afd90.
❤️ 💚 💙 💛 💜

@maclover7 maclover7 closed this Dec 6, 2017
maclover7 pushed a commit that referenced this pull request Dec 6, 2017
@Leko @maclover7
test: replace assert.throws with common.expectsError
50afd90 
PR-URL: #17445
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Leko @MylesBorins
test: replace assert.throws with common.expectsError
03f7ed8 
PR-URL: #17445
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Leko @MylesBorins
test: replace assert.throws with common.expectsError
0ac87c2 
PR-URL: #17445
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Leko @gibfahn
test: replace assert.throws with common.expectsError
babb288 
PR-URL: #17445
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Leko @gibfahn
test: replace assert.throws with common.expectsError
e01cd82 
PR-URL: #17445
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
@Leko
test: replace assert.throws with common.expectsError
3f4ac09 
PR-URL: nodejs#17445
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@Leko @MylesBorins
test: replace assert.throws with common.expectsError
e54b58c 
Backport-PR-URL: #19447
PR-URL: #17445
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@maclover7 maclover7 maclover7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maclover7 maclover7

Labels

node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Leko @lpinca @maclover7 @jasnell @cjihrig @addaleax @gibfahn @nodejs-github-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.