Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 0257e80

Browse filesBrowse files
addaleaxaduh95
addaleax
authored and
aduh95
committed
src: make AsyncWrap subclass internal field counts explicit
This helps ensure that we already set the correct number of internal fields when creating objects, even if the number of internal fields of e.g. AsyncWrap changes over time. PR-URL: #62103 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent eeee7c7 commit 0257e80
Copy full SHA for 0257e80

32 files changed

+130-55Lines changed: 130 additions & 55 deletions
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/async_wrap-inl.h‎

Copy file name to clipboardExpand all lines: src/async_wrap-inl.h
+9Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,15 @@ inline v8::Local<v8::FunctionTemplate> AsyncWrap::GetConstructorTemplate(
8989
return GetConstructorTemplate(env->isolate_data());
9090
}
9191

92+
// static
93+
v8::Local<v8::FunctionTemplate> AsyncWrap::MakeLazilyInitializedJSTemplate(
94+
Environment* env, int internal_field_count) {
95+
v8::Local<v8::FunctionTemplate> t =
96+
BaseObject::MakeLazilyInitializedJSTemplate(env, internal_field_count);
97+
t->Inherit(AsyncWrap::GetConstructorTemplate(env));
98+
return t;
99+
}
100+
92101
} // namespace node
93102

94103
#endif // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
Collapse file

‎src/async_wrap.h‎

Copy file name to clipboardExpand all lines: src/async_wrap.h
+7Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,10 @@ class ExternalReferenceRegistry;
118118

119119
class AsyncWrap : public BaseObject {
120120
public:
121+
enum InternalFields {
122+
kInternalFieldCount = BaseObject::kInternalFieldCount,
123+
};
124+
121125
enum ProviderType {
122126
#define V(PROVIDER) \
123127
PROVIDER_ ## PROVIDER,
@@ -229,6 +233,9 @@ class AsyncWrap : public BaseObject {
229233

230234
bool IsDoneInitializing() const override;
231235

236+
static inline v8::Local<v8::FunctionTemplate> MakeLazilyInitializedJSTemplate(
237+
Environment* env, int internal_field_count = kInternalFieldCount);
238+
232239
private:
233240
ProviderType provider_type_ = PROVIDER_NONE;
234241
bool init_hook_ran_ = false;
Collapse file

‎src/base_object.cc‎

Copy file name to clipboardExpand all lines: src/base_object.cc
+5-4Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,15 +81,16 @@ void BaseObject::LazilyInitializedJSTemplateConstructor(
8181
}
8282

8383
Local<FunctionTemplate> BaseObject::MakeLazilyInitializedJSTemplate(
84-
Environment* env) {
85-
return MakeLazilyInitializedJSTemplate(env->isolate_data());
84+
Environment* env, int internal_field_count) {
85+
return MakeLazilyInitializedJSTemplate(env->isolate_data(),
86+
internal_field_count);
8687
}
8788

8889
Local<FunctionTemplate> BaseObject::MakeLazilyInitializedJSTemplate(
89-
IsolateData* isolate_data) {
90+
IsolateData* isolate_data, int internal_field_count) {
9091
Local<FunctionTemplate> t = NewFunctionTemplate(
9192
isolate_data->isolate(), LazilyInitializedJSTemplateConstructor);
92-
t->InstanceTemplate()->SetInternalFieldCount(BaseObject::kInternalFieldCount);
93+
t->InstanceTemplate()->SetInternalFieldCount(internal_field_count);
9394
return t;
9495
}
9596

Collapse file

‎src/base_object.h‎

Copy file name to clipboardExpand all lines: src/base_object.h
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,9 @@ class BaseObject : public MemoryRetainer {
109109
// the `BaseObject*` pointer) and a constructor that initializes that field
110110
// to `nullptr`.
111111
static v8::Local<v8::FunctionTemplate> MakeLazilyInitializedJSTemplate(
112-
IsolateData* isolate);
112+
IsolateData* isolate, int internal_field_count = kInternalFieldCount);
113113
static v8::Local<v8::FunctionTemplate> MakeLazilyInitializedJSTemplate(
114-
Environment* env);
114+
Environment* env, int internal_field_count = kInternalFieldCount);
115115

116116
// Setter/Getter pair for internal fields that can be passed to SetAccessor.
117117
template <int Field>
Collapse file

‎src/cares_wrap.cc‎

Copy file name to clipboardExpand all lines: src/cares_wrap.cc
+3-9Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2318,19 +2318,13 @@ void Initialize(Local<Object> target,
23182318
NODE_DEFINE_CONSTANT(target, DNS_ORDER_IPV4_FIRST);
23192319
NODE_DEFINE_CONSTANT(target, DNS_ORDER_IPV6_FIRST);
23202320

2321-
Local<FunctionTemplate> aiw =
2322-
BaseObject::MakeLazilyInitializedJSTemplate(env);
2323-
aiw->Inherit(AsyncWrap::GetConstructorTemplate(env));
2321+
Local<FunctionTemplate> aiw = AsyncWrap::MakeLazilyInitializedJSTemplate(env);
23242322
SetConstructorFunction(context, target, "GetAddrInfoReqWrap", aiw);
23252323

2326-
Local<FunctionTemplate> niw =
2327-
BaseObject::MakeLazilyInitializedJSTemplate(env);
2328-
niw->Inherit(AsyncWrap::GetConstructorTemplate(env));
2324+
Local<FunctionTemplate> niw = AsyncWrap::MakeLazilyInitializedJSTemplate(env);
23292325
SetConstructorFunction(context, target, "GetNameInfoReqWrap", niw);
23302326

2331-
Local<FunctionTemplate> qrw =
2332-
BaseObject::MakeLazilyInitializedJSTemplate(env);
2333-
qrw->Inherit(AsyncWrap::GetConstructorTemplate(env));
2327+
Local<FunctionTemplate> qrw = AsyncWrap::MakeLazilyInitializedJSTemplate(env);
23342328
SetConstructorFunction(context, target, "QueryReqWrap", qrw);
23352329

23362330
Local<FunctionTemplate> channel_wrap =
Collapse file

‎src/crypto/crypto_keys.cc‎

Copy file name to clipboardExpand all lines: src/crypto/crypto_keys.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1217,7 +1217,7 @@ void NativeKeyObject::CreateNativeKeyObjectClass(
12171217
Local<FunctionTemplate> t =
12181218
NewFunctionTemplate(isolate, NativeKeyObject::New);
12191219
t->InstanceTemplate()->SetInternalFieldCount(
1220-
KeyObjectHandle::kInternalFieldCount);
1220+
NativeKeyObject::kInternalFieldCount);
12211221

12221222
Local<Value> ctor;
12231223
if (!t->GetFunction(env->context()).ToLocal(&ctor))
Collapse file

‎src/crypto/crypto_sig.cc‎

Copy file name to clipboardExpand all lines: src/crypto/crypto_sig.cc
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ void Sign::Initialize(Environment* env, Local<Object> target) {
310310
Isolate* isolate = env->isolate();
311311
Local<FunctionTemplate> t = NewFunctionTemplate(isolate, New);
312312

313-
t->InstanceTemplate()->SetInternalFieldCount(SignBase::kInternalFieldCount);
313+
t->InstanceTemplate()->SetInternalFieldCount(Sign::kInternalFieldCount);
314314

315315
SetProtoMethod(isolate, t, "init", SignInit);
316316
SetProtoMethod(isolate, t, "update", SignUpdate);
@@ -437,7 +437,7 @@ void Verify::Initialize(Environment* env, Local<Object> target) {
437437
Isolate* isolate = env->isolate();
438438
Local<FunctionTemplate> t = NewFunctionTemplate(isolate, New);
439439

440-
t->InstanceTemplate()->SetInternalFieldCount(SignBase::kInternalFieldCount);
440+
t->InstanceTemplate()->SetInternalFieldCount(Verify::kInternalFieldCount);
441441

442442
SetProtoMethod(isolate, t, "init", VerifyInit);
443443
SetProtoMethod(isolate, t, "update", VerifyUpdate);
Collapse file

‎src/crypto/crypto_tls.cc‎

Copy file name to clipboardExpand all lines: src/crypto/crypto_tls.cc
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2172,11 +2172,11 @@ void TLSWrap::Initialize(
21722172

21732173
NODE_DEFINE_CONSTANT(target, HAVE_SSL_TRACE);
21742174

2175-
Local<FunctionTemplate> t = BaseObject::MakeLazilyInitializedJSTemplate(env);
2175+
Local<FunctionTemplate> t = AsyncWrap::MakeLazilyInitializedJSTemplate(env);
21762176
Local<String> tlsWrapString =
21772177
FIXED_ONE_BYTE_STRING(env->isolate(), "TLSWrap");
21782178
t->SetClassName(tlsWrapString);
2179-
t->InstanceTemplate()->SetInternalFieldCount(StreamBase::kInternalFieldCount);
2179+
t->InstanceTemplate()->SetInternalFieldCount(TLSWrap::kInternalFieldCount);
21802180

21812181
Local<FunctionTemplate> get_write_queue_size =
21822182
FunctionTemplate::New(env->isolate(),
Collapse file

‎src/crypto/crypto_tls.h‎

Copy file name to clipboardExpand all lines: src/crypto/crypto_tls.h
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,11 @@ class TLSWrap : public AsyncWrap,
4343
public StreamBase,
4444
public StreamListener {
4545
public:
46+
enum InternalFields {
47+
kInternalFieldCount = std::max<uint32_t>(AsyncWrap::kInternalFieldCount,
48+
StreamBase::kInternalFieldCount),
49+
};
50+
4651
enum class Kind {
4752
kClient,
4853
kServer
Collapse file

‎src/crypto/crypto_util.h‎

Copy file name to clipboardExpand all lines: src/crypto/crypto_util.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ class CryptoJob : public AsyncWrap, public ThreadPoolWork {
348348
v8::Local<v8::FunctionTemplate> job = NewFunctionTemplate(isolate, new_fn);
349349
job->Inherit(AsyncWrap::GetConstructorTemplate(env));
350350
job->InstanceTemplate()->SetInternalFieldCount(
351-
AsyncWrap::kInternalFieldCount);
351+
CryptoJob::kInternalFieldCount);
352352
SetProtoMethod(isolate, job, "run", Run);
353353
SetConstructorFunction(context, target, CryptoJobTraits::JobName, job);
354354
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.