Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: get correct commit message and PR title for auto PRs#1691

Merged
SimenB merged 1 commit into
nodejs:mainnodejs/docker-node:mainfrom
SimenB:correct-script-outputSimenB/docker-node:correct-script-outputCopy head branch name to clipboard
Apr 8, 2022
Merged

fix: get correct commit message and PR title for auto PRs#1691
SimenB merged 1 commit into
nodejs:mainnodejs/docker-node:mainfrom
SimenB:correct-script-outputSimenB/docker-node:correct-script-outputCopy head branch name to clipboard

Conversation

@SimenB

@SimenB SimenB commented Apr 7, 2022

Copy link
Copy Markdown
Member

See #1688 which is missing the versions. I think by returning JSON we need to parse it in the later step. Since we only use the string, returning that directly seems easier.

https://github.com/actions/github-script/blob/9bd6ae64c1b3b9677eba79c33befd8c1c45088c0/src/main.ts#L54

@SimenB SimenB requested a review from a team April 7, 2022 12:52
@SimenB SimenB force-pushed the correct-script-output branch from 3496974 to 7b418d1 Compare April 7, 2022 12:52
@SimenB SimenB merged commit d40c2c8 into nodejs:main Apr 8, 2022
@SimenB SimenB deleted the correct-script-output branch April 8, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.