Add noMutate flag, which addresses #12 and adds the ability to…#15
Merged
maxkorp merged 1 commit intonodegit:masternodegit/promisify-node:masterfrom Nov 30, 2015
jon-hall:feature/mutating-required-modules-bugjon-hall/promisify-node:feature/mutating-required-modules-bugCopy head branch name to clipboard
Merged
Add noMutate flag, which addresses #12 and adds the ability to…#15maxkorp merged 1 commit intonodegit:masternodegit/promisify-node:masterfrom jon-hall:feature/mutating-required-modules-bugjon-hall/promisify-node:feature/mutating-required-modules-bugCopy head branch name to clipboard
maxkorp merged 1 commit intonodegit:masternodegit/promisify-node:masterfrom
jon-hall:feature/mutating-required-modules-bugjon-hall/promisify-node:feature/mutating-required-modules-bugCopy head branch name to clipboard
Conversation
Contributor
|
As i said in your other PR, pending hearing back from other maintainers re: dropping 0.8 support, this should be good to merge 👍. Thanks a ton for grabbing both of these man ❤️ |
Contributor
|
Can you rebase this on top of master please, to get the updated version matrix (it doesnt appear there were any other changes, so a rebase should be safe). |
8a5bc4d to
0989ca8
Compare
Contributor
Author
|
Heh, beat me to it with the other PR! Will rebase and try again 👍. |
… disable object mutation through the public API.
0989ca8 to
73f8216
Compare
Contributor
|
💥 |
maxkorp
added a commit
that referenced
this pull request
Nov 30, 2015
…s-bug Add noMutate flag, which addresses #12 and adds the ability to…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…disable object mutation through the public API.
This ended up needing some fairly significant changes, but I think being able to prevent mutation (particularly for the case of require calls, as in #12) is a very helpful feature that does warrant it.