Make compatible with promisify-node 0.4.0#1365
Closed
olivierlemasle wants to merge 1 commit intonodegit:masternodegit/nodegit:masterfrom
olivierlemasle:upgrade-promisify-nodeolivierlemasle/nodegit:upgrade-promisify-nodeCopy head branch name to clipboard
Closed
Make compatible with promisify-node 0.4.0#1365olivierlemasle wants to merge 1 commit intonodegit:masternodegit/nodegit:masterfrom olivierlemasle:upgrade-promisify-nodeolivierlemasle/nodegit:upgrade-promisify-nodeCopy head branch name to clipboard
olivierlemasle wants to merge 1 commit intonodegit:masternodegit/nodegit:masterfrom
olivierlemasle:upgrade-promisify-nodeolivierlemasle/nodegit:upgrade-promisify-nodeCopy head branch name to clipboard
Conversation
The `test` function is required to force promisify-node to promisify native functions, because async inference based on argument's names cannot work on native functions. With promisify-node ~0.3.0, functions were always promisify, even if they were not considered asynchronous by async inference.
Merged
Author
|
Superseded by #1519. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testfunction is required to force promisify-node to promisify native functions, because async inference based on argument's names cannot work on native functions.With promisify-node ~0.3.0, functions were always promisify, even if they were not considered asynchronous by async inference. The change of behavior was introduced "insidiously" in nodegit/promisify-node#15.