Renable click to close for edit dialog#5567
Merged
Renable click to close for edit dialog#5567
Conversation
Contributor
|
Does this emulate Done or Cancel? |
Contributor
Triggers |
Member
Author
|
Same behaviour we had for 10 years previously 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the long-held behaviour of closing the edit dialog when clicking on the workspace outside the dialog. We've only had negative feedback on the change - which is somewhat self-selecting (why comment on something you like).
The alternative is to give the user a choice of behaviours. I'm very keen to avoid adding config options for small bits of UI behaviour - they set an expectation that anything and everything should be customisable, and become hard to maintain.
I've going to merge this for the next beta to gauge feedback on reverting. We can still go with #5385 if we really must.