Add several click-outside-edit-tray behaviors#5385
Open
GogoVega wants to merge 1 commit intonode-red:masternode-red/node-red:masterfrom
GogoVega:5247-click-outside-edit-trayGogoVega/node-red:5247-click-outside-edit-trayCopy head branch name to clipboard
Open
Add several click-outside-edit-tray behaviors#5385GogoVega wants to merge 1 commit intonode-red:masternode-red/node-red:masterfrom GogoVega:5247-click-outside-edit-trayGogoVega/node-red:5247-click-outside-edit-trayCopy head branch name to clipboard
GogoVega wants to merge 1 commit intonode-red:masternode-red/node-red:masterfrom
GogoVega:5247-click-outside-edit-trayGogoVega/node-red:5247-click-outside-edit-trayCopy head branch name to clipboard
Conversation
codeCraft-Ritik
left a comment
There was a problem hiding this comment.
Great attention to detail throughout the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Proposed changes
Closes #5247.
Foreword: The purpose of that change was to prevent changes from being saved when clicking outside the edit tray and a poor revert is not enough to move forward... In theory, the changes should be discard, but in practice, users have their own preferences.
Revert the click-outside-edit-tray behavior to save changes and close the edit tray.
Also adds to the settings a selection input to allow the user to choose the desired behavior. The options and their behavior are as follows:
nothing: do nothingdiscard: discard changes and closesave: save changes and closeChecklist
npm run testto verify the unit tests pass