Add pause/resume handling to part passed to onPart.#388
Open
uformia wants to merge 3 commits into
node-formidable:masternode-formidable/formidable:masterfrom
uformia:form-part-prevent-bufferinguformia/node-formidable:form-part-prevent-bufferingCopy head branch name to clipboard
Open
Add pause/resume handling to part passed to onPart.#388uformia wants to merge 3 commits intonode-formidable:masternode-formidable/formidable:masterfrom uformia:form-part-prevent-bufferinguformia/node-formidable:form-part-prevent-bufferingCopy head branch name to clipboard
uformia wants to merge 3 commits into
node-formidable:masternode-formidable/formidable:masterfrom
uformia:form-part-prevent-bufferinguformia/node-formidable:form-part-prevent-bufferingCopy head branch name to clipboard
Conversation
…g if part is pipe'd.
Collaborator
|
See #412 |
Contributor
|
Can you add a test for it? |
Getting updates from upstream.
Pull updates from master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pause/resume handling to part passed to onPart. Prevents buffering if part is pipe'd.
Use case is when onPart is overridden, and the part is being pipe'd to a slow stream (e.g. remote server), and incoming data is sent faster than outgoing link can handle.